mbox series

[0/4] btrfs: fix issues due to alien device

Message ID 1570175403-4073-1-git-send-email-anand.jain@oracle.com (mailing list archive)
Headers show
Series btrfs: fix issues due to alien device | expand

Message

Anand Jain Oct. 4, 2019, 7:49 a.m. UTC
Alien device is a device in fs_devices list having a different fsid than
the expected fsid. This patch set fixes issues found due to the same.

Patch1: is a cleanup patch, not related.
Patch2: fixes the missing device not missing in the userland, by
        hardening the function btrfs_open_one_device().
Patch3: fixes failing to mount a degraded RAID1 (but it can apply
        to RAID5/6/10 as well), by hardening the function
	btrfs_free_extra_devids().
Patch4: eliminates the source of the alien device in the fs_devices.

Anand Jain (4):
  btrfs: drop useless goto in open_fs_devices
  btrfs: delete identified alien device in open_fs_devices
  btrfs: include non-missing as a qualifier for the latest_bdev
  btrfs: free alien device due to device add

 fs/btrfs/volumes.c | 40 ++++++++++++++++++++++++++++++----------
 1 file changed, 30 insertions(+), 10 deletions(-)

Comments

Nikolay Borisov Oct. 4, 2019, 8:19 a.m. UTC | #1
On 4.10.19 г. 10:49 ч., Anand Jain wrote:
> Alien device is a device in fs_devices list having a different fsid than
> the expected fsid. This patch set fixes issues found due to the same.

Are you going to submit an fstests patch for this bug ?

> 
> Patch1: is a cleanup patch, not related.
> Patch2: fixes the missing device not missing in the userland, by
>         hardening the function btrfs_open_one_device().
> Patch3: fixes failing to mount a degraded RAID1 (but it can apply
>         to RAID5/6/10 as well), by hardening the function
> 	btrfs_free_extra_devids().
> Patch4: eliminates the source of the alien device in the fs_devices.
> 
> Anand Jain (4):
>   btrfs: drop useless goto in open_fs_devices
>   btrfs: delete identified alien device in open_fs_devices
>   btrfs: include non-missing as a qualifier for the latest_bdev
>   btrfs: free alien device due to device add
> 
>  fs/btrfs/volumes.c | 40 ++++++++++++++++++++++++++++++----------
>  1 file changed, 30 insertions(+), 10 deletions(-)
>
Anand Jain Oct. 7, 2019, 9:42 a.m. UTC | #2
On 4/10/19 4:19 PM, Nikolay Borisov wrote:
> 
> 
> On 4.10.19 г. 10:49 ч., Anand Jain wrote:
>> Alien device is a device in fs_devices list having a different fsid than
>> the expected fsid. This patch set fixes issues found due to the same.
> 
> Are you going to submit an fstests patch for this bug ?

  Yes. Done.