From patchwork Wed Mar 27 07:24:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qu Wenruo X-Patchwork-Id: 10872823 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C7CC4139A for ; Wed, 27 Mar 2019 07:25:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A373B28D2A for ; Wed, 27 Mar 2019 07:25:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 97B8C28D51; Wed, 27 Mar 2019 07:25:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 399F928D2A for ; Wed, 27 Mar 2019 07:25:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731583AbfC0HZG (ORCPT ); Wed, 27 Mar 2019 03:25:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:39542 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725997AbfC0HZG (ORCPT ); Wed, 27 Mar 2019 03:25:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id AE844ADC7 for ; Wed, 27 Mar 2019 07:25:04 +0000 (UTC) From: Qu Wenruo To: linux-btrfs@vger.kernel.org Subject: [PATCH URGENT 0/2] btrfs-progs: Fix the nobarrier behavior of write Date: Wed, 27 Mar 2019 15:24:58 +0800 Message-Id: <20190327072500.11156-1-wqu@suse.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This urgent patchset can be fetched from github: https://github.com/adam900710/btrfs-progs/tree/flush_super Which is based on v4.20.2. Before this patch, btrfs-progs writes to the fs has no barrier at all. All metadata and superblock are just buffered write, no barrier between super blocks and metadata writes at all. No wonder why even clear space cache can cause serious transid corruption to the originally good fs. Please merge this fix as soon as possible as I really don't want to see btrfs-progs corrupting any fs any more. Qu Wenruo (2): btrfs-progs: disk-io: Make super block write error more easy to read btrfs-progs: disk-io: Flush to ensure super block write is FUA disk-io.c | 45 +++++++++++++++++++++++++++++++++++++++------ 1 file changed, 39 insertions(+), 6 deletions(-)