mbox series

[00/11] btrfs: move the space_info code out of extent-tree.c

Message ID 20190618200926.3352-1-josef@toxicpanda.com (mailing list archive)
Headers show
Series btrfs: move the space_info code out of extent-tree.c | expand

Message

Josef Bacik June 18, 2019, 8:09 p.m. UTC
This is the first pass at making extent-tree.c much smaller.  I've purposefully
done no other cleanups or changes.  The places where I needed to modify callers
were done in separate patches.  The only time I moved and changed callers in
large chunks was the moving of reserve_metadata_bytes out of extent-tree.c, and
that was just to rename the users of reserve_metadata_bytes to
btrfs_reserve_metadata_bytes.

There is 0 functional change in this series.  The next step is to move the other
space reservation code that is specific to delayed_refs, inodes, etc.  But I
wanted to start with this to make sure we're all onboard with this approach
before I do other things.

The diffstat for the whole series is the following

 fs/btrfs/Makefile           |    2 +-
 fs/btrfs/ctree.h            |   97 +---
 fs/btrfs/extent-tree.c      | 1277 +++----------------------------------------
 fs/btrfs/free-space-cache.c |    1 +
 fs/btrfs/ioctl.c            |    1 +
 fs/btrfs/space-info.c       | 1103 +++++++++++++++++++++++++++++++++++++
 fs/btrfs/space-info.h       |  135 +++++
 fs/btrfs/super.c            |    1 +
 fs/btrfs/sysfs.c            |    1 +
 fs/btrfs/volumes.c          |    1 +
 10 files changed, 1343 insertions(+), 1276 deletions(-)

Thanks,

Josef

Comments

Nikolay Borisov June 20, 2019, 7:42 a.m. UTC | #1
On 18.06.19 г. 23:09 ч., Josef Bacik wrote:
> This is the first pass at making extent-tree.c much smaller.  I've purposefully
> done no other cleanups or changes.  The places where I needed to modify callers
> were done in separate patches.  The only time I moved and changed callers in
> large chunks was the moving of reserve_metadata_bytes out of extent-tree.c, and
> that was just to rename the users of reserve_metadata_bytes to
> btrfs_reserve_metadata_bytes.
> 
> There is 0 functional change in this series.  The next step is to move the other
> space reservation code that is specific to delayed_refs, inodes, etc.  But I
> wanted to start with this to make sure we're all onboard with this approach
> before I do other things.
> 
> The diffstat for the whole series is the following

Looks good,

Reviewed-by: Nikolay Borisov <nborisov@suse.com>

> 
>  fs/btrfs/Makefile           |    2 +-
>  fs/btrfs/ctree.h            |   97 +---
>  fs/btrfs/extent-tree.c      | 1277 +++----------------------------------------
>  fs/btrfs/free-space-cache.c |    1 +
>  fs/btrfs/ioctl.c            |    1 +
>  fs/btrfs/space-info.c       | 1103 +++++++++++++++++++++++++++++++++++++
>  fs/btrfs/space-info.h       |  135 +++++
>  fs/btrfs/super.c            |    1 +
>  fs/btrfs/sysfs.c            |    1 +
>  fs/btrfs/volumes.c          |    1 +
>  10 files changed, 1343 insertions(+), 1276 deletions(-)
> 
> Thanks,
> 
> Josef
>
David Sterba June 25, 2019, 4:44 p.m. UTC | #2
On Tue, Jun 18, 2019 at 04:09:15PM -0400, Josef Bacik wrote:
> This is the first pass at making extent-tree.c much smaller.  I've purposefully
> done no other cleanups or changes.  The places where I needed to modify callers
> were done in separate patches.  The only time I moved and changed callers in
> large chunks was the moving of reserve_metadata_bytes out of extent-tree.c, and
> that was just to rename the users of reserve_metadata_bytes to
> btrfs_reserve_metadata_bytes.
> 
> There is 0 functional change in this series.  The next step is to move the other
> space reservation code that is specific to delayed_refs, inodes, etc.  But I
> wanted to start with this to make sure we're all onboard with this approach
> before I do other things.
> 
> The diffstat for the whole series is the following
> 
>  fs/btrfs/Makefile           |    2 +-
>  fs/btrfs/ctree.h            |   97 +---
>  fs/btrfs/extent-tree.c      | 1277 +++----------------------------------------
>  fs/btrfs/free-space-cache.c |    1 +
>  fs/btrfs/ioctl.c            |    1 +
>  fs/btrfs/space-info.c       | 1103 +++++++++++++++++++++++++++++++++++++
>  fs/btrfs/space-info.h       |  135 +++++
>  fs/btrfs/super.c            |    1 +
>  fs/btrfs/sysfs.c            |    1 +
>  fs/btrfs/volumes.c          |    1 +
>  10 files changed, 1343 insertions(+), 1276 deletions(-)

With the removed copyright notice, patches added to misc-next.