| Message ID | 20190705072651.25150-1-wqu@suse.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | btrfs-progs: tests: Make 64K page size system happier | expand |
On Fri, Jul 05, 2019 at 03:26:46PM +0800, Qu Wenruo wrote: > Since I got another rockpro64, finally I could do some tests with > aarch64 64K page size mode. (The first board is working as a NAS for > a while) > > Unsurprisingly there are several false test alerts in btrfs-progs > selftests. > > Although there is no existing CI service based on 64K page sized system, > we'd better support for 64K page size as it's easier and easier to get > SBC with good enough aarch64 SoC to compile kernel/btrfs-progs and run > various tests on them. > > The first patch fix a bug which mkfs can't accept any sector size on 64K > page size system. > > The remaining patches enhance test cases to make them work on 64K page > size system (skip those tests unless kernel support subpage sized sector > size) > > Qu Wenruo (5): > btrfs-progs: mkfs: Apply the sectorsize user specified on 64k page > size system > btrfs-progs: fsck-tests: Check if current kernel can mount fs with > specified sector size > btrfs-progs: mkfs-tests: Skip 010-minimal-size if we can't mount with > 4k sector size > btrfs-progs: misc-tests: Make test cases work or skipped on 64K page > size system > btrfs-progs: convert-tests: Skip tests if kernel doesn't support > subpage sized sector size The fix is ok, but the test updates and pre-checks do not seem right to me. The check_preerq helpers are for binaries and rather simple checks unlike what the mkfs/mount test for 4k sectors does. I'll reply under the patches with more specific comments.
Since I got another rockpro64, finally I could do some tests with aarch64 64K page size mode. (The first board is working as a NAS for a while) Unsurprisingly there are several false test alerts in btrfs-progs selftests. Although there is no existing CI service based on 64K page sized system, we'd better support for 64K page size as it's easier and easier to get SBC with good enough aarch64 SoC to compile kernel/btrfs-progs and run various tests on them. The first patch fix a bug which mkfs can't accept any sector size on 64K page size system. The remaining patches enhance test cases to make them work on 64K page size system (skip those tests unless kernel support subpage sized sector size) Qu Wenruo (5): btrfs-progs: mkfs: Apply the sectorsize user specified on 64k page size system btrfs-progs: fsck-tests: Check if current kernel can mount fs with specified sector size btrfs-progs: mkfs-tests: Skip 010-minimal-size if we can't mount with 4k sector size btrfs-progs: misc-tests: Make test cases work or skipped on 64K page size system btrfs-progs: convert-tests: Skip tests if kernel doesn't support subpage sized sector size mkfs/main.c | 12 +++++- tests/common | 29 +++++++++++++ tests/convert-tests/001-ext2-basic/test.sh | 1 + tests/convert-tests/002-ext3-basic/test.sh | 1 + tests/convert-tests/003-ext4-basic/test.sh | 1 + .../004-ext2-backup-superblock-ranges/test.sh | 1 + .../005-delete-all-rollback/test.sh | 1 + .../006-large-hole-extent/test.sh | 2 + .../convert-tests/008-readonly-image/test.sh | 1 + .../009-common-inode-flags/test.sh | 1 + .../convert-tests/010-reiserfs-basic/test.sh | 2 + .../011-reiserfs-delete-all-rollback/test.sh | 1 + .../012-reiserfs-large-hole-extent/test.sh | 1 + .../013-reiserfs-common-inode-flags/test.sh | 1 + .../014-reiserfs-tail-handling/test.sh | 1 + .../015-no-rollback-after-balance/test.sh | 1 + .../016-invalid-large-inline-extent/test.sh | 1 + tests/fsck-tests/012-leaf-corruption/test.sh | 1 + .../028-unaligned-super-dev-sizes/test.sh | 1 + .../037-freespacetree-repair/test.sh | 3 +- .../010-convert-delete-ext2-subvol/test.sh | 5 ++- tests/mkfs-tests/010-minimal-size/test.sh | 41 ++++++++++--------- 22 files changed, 86 insertions(+), 23 deletions(-)