mbox series

[0/6] btrfs-progs: add support for LOGICAL_INO_V2 features in logical-resolve

Message ID 20191127035509.15011-1-ce3g8jdj@umail.furryterror.org (mailing list archive)
Headers show
Series btrfs-progs: add support for LOGICAL_INO_V2 features in logical-resolve | expand

Message

Zygo Blaxell Nov. 27, 2019, 3:55 a.m. UTC
This patch set adds support for LOGICAL_INO_V2 features:

        - bigger buffer size (16M instead of 64K, default also increased to 64K)

        - IGNORE_OFFSETS flag to look up references by extent instead of block

If the V2 options are used, it calls the V2 ioctl; otherwise, it calls
the V1 ioctl for old kernel compatibility.

Comments

Anand Jain Dec. 2, 2019, 11:02 a.m. UTC | #1
On 27/11/19 11:55 AM, Zygo Blaxell wrote:
> This patch set adds support for LOGICAL_INO_V2 features:
> 
>          - bigger buffer size (16M instead of 64K, default also increased to 64K)
> 
>          - IGNORE_OFFSETS flag to look up references by extent instead of block
> 
> If the V2 options are used, it calls the V2 ioctl; otherwise, it calls
> the V1 ioctl for old kernel compatibility.
> 
> 

For the whole series.

Reviewed-by: Anand Jain <anand.jain@oracle.com>

(Nit: This should be v4 as this patch was submitted before:

https://lore.kernel.org/linux-btrfs/20170922175847.6071-1-ce3g8jdj@umail.furryterror.org/T/#t
)
Zygo Blaxell Dec. 2, 2019, 6:42 p.m. UTC | #2
On Mon, Dec 02, 2019 at 07:02:26PM +0800, Anand Jain wrote:
> On 27/11/19 11:55 AM, Zygo Blaxell wrote:
> > This patch set adds support for LOGICAL_INO_V2 features:
> > 
> >          - bigger buffer size (16M instead of 64K, default also increased to 64K)
> > 
> >          - IGNORE_OFFSETS flag to look up references by extent instead of block
> > 
> > If the V2 options are used, it calls the V2 ioctl; otherwise, it calls
> > the V1 ioctl for old kernel compatibility.
> > 
> > 
> 
> For the whole series.
> 
> Reviewed-by: Anand Jain <anand.jain@oracle.com>
> 
> (Nit: This should be v4 as this patch was submitted before:
> 
> https://lore.kernel.org/linux-btrfs/20170922175847.6071-1-ce3g8jdj@umail.furryterror.org/T/#t

Nit^2:  That was the kernel patch, this is a btrfs-progs patch to use
the kernel feature.

I'm assuming kernel and userspace patches get different version
numbering...?

> 
>
Anand Jain Dec. 3, 2019, 1:08 a.m. UTC | #3
On 12/3/19 2:42 AM, Zygo Blaxell wrote:
> On Mon, Dec 02, 2019 at 07:02:26PM +0800, Anand Jain wrote:
>> On 27/11/19 11:55 AM, Zygo Blaxell wrote:
>>> This patch set adds support for LOGICAL_INO_V2 features:
>>>
>>>           - bigger buffer size (16M instead of 64K, default also increased to 64K)
>>>
>>>           - IGNORE_OFFSETS flag to look up references by extent instead of block
>>>
>>> If the V2 options are used, it calls the V2 ioctl; otherwise, it calls
>>> the V1 ioctl for old kernel compatibility.
>>>
>>>
>>
>> For the whole series.
>>
>> Reviewed-by: Anand Jain <anand.jain@oracle.com>
>>
>> (Nit: This should be v4 as this patch was submitted before:
>>
>> https://lore.kernel.org/linux-btrfs/20170922175847.6071-1-ce3g8jdj@umail.furryterror.org/T/#t
> 
> Nit^2:  That was the kernel patch, this is a btrfs-progs patch to use
> the kernel feature.
> 
> I'm assuming kernel and userspace patches get different version
> numbering...?

  Ah. After I commented on the kernel patch at the above link,
  I remember seeing the progs patches which I can't find now.
  And I got confused with the kernel patch. Ok this isn't v4.

Thanks, Anand

>>
>>
David Sterba Jan. 2, 2020, 7 p.m. UTC | #4
On Tue, Nov 26, 2019 at 10:55:03PM -0500, Zygo Blaxell wrote:
> This patch set adds support for LOGICAL_INO_V2 features:
> 
>         - bigger buffer size (16M instead of 64K, default also increased to 64K)
> 
>         - IGNORE_OFFSETS flag to look up references by extent instead of block
> 
> If the V2 options are used, it calls the V2 ioctl; otherwise, it calls
> the V1 ioctl for old kernel compatibility.

Thanks, I've added the patchset to devel.