[0/3] Fix transaction abort when rmdir'ing a subvol

Message

Josef Bacik Dec. 18, 2019, 10:20 p.m. UTC

btrfs/004 with my new fsstress was sometimes failing with a transaction abort
while trying to remove a root ref.  This turned out to be because of how we stub
out subvol links in snapshot'ed subvolumes.  The specific steps are detailed in
"btrfs: fix invalid removal of root ref", but they are relatively
straightforward.  A xfstest is forthcoming, I want to get an overnight run of
fsstress with these patches in place to make sure there are no other
rename+removal shenanigans left.  With these patches we pass my basic test and
no longer abort the transaction.  Thanks,

Josef

Comments

David Sterba Jan. 3, 2020, 5:08 p.m. UTC | #1

On Wed, Dec 18, 2019 at 05:20:26PM -0500, Josef Bacik wrote:
> btrfs/004 with my new fsstress was sometimes failing with a transaction abort
> while trying to remove a root ref.  This turned out to be because of how we stub
> out subvol links in snapshot'ed subvolumes.  The specific steps are detailed in
> "btrfs: fix invalid removal of root ref", but they are relatively
> straightforward.  A xfstest is forthcoming, I want to get an overnight run of
> fsstress with these patches in place to make sure there are no other
> rename+removal shenanigans left.  With these patches we pass my basic test and
> no longer abort the transaction.  Thanks,

Reviewed-by: David Sterba <[e-mail]>

As 2 and 3 are the real fixes, independent of 1, I'll queue them for
next week's pull request.