From patchwork Fri May 22 12:38:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Goldwyn Rodrigues X-Patchwork-Id: 11565523 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CEB701392 for ; Fri, 22 May 2020 12:38:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C290E206D5 for ; Fri, 22 May 2020 12:38:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729344AbgEVMiz (ORCPT ); Fri, 22 May 2020 08:38:55 -0400 Received: from mx2.suse.de ([195.135.220.15]:59014 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728801AbgEVMiz (ORCPT ); Fri, 22 May 2020 08:38:55 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 3D499AD46; Fri, 22 May 2020 12:38:57 +0000 (UTC) From: Goldwyn Rodrigues To: linux-btrfs@vger.kernel.org Cc: hch@infradead.org, dsterba@suse.cz Subject: [PATCH 0/7 v8] btrfs direct-io using iomap Date: Fri, 22 May 2020 07:38:30 -0500 Message-Id: <20200522123837.1196-1-rgoldwyn@suse.de> X-Mailer: git-send-email 2.25.0 MIME-Version: 1.0 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org This is an effort to use iomap for direct I/O in btrfs. This would change the call from __blockdev_direct_io() to iomap_dio_rw(). The main objective is to lose the buffer head and use bio defined by iomap code, and hopefully to use more of generic-FS codebase. These patches are based and tested on kdave/for-next-20200511. I have tested it against xfstests/btrfs. The tree is available at https://github.com/goldwynr/linux/tree/dio-merge Changes since v1 - Incorporated back the efficiency change for inode locking - Review comments about coding style and git comments - Merge related patches into one - Direct read to go through btrfs_direct_IO() - Removal of no longer used function dio_end_io() Changes since v2 - aligning iomap offset/length to the position/length of I/O - Removed btrfs_dio_data - Removed BTRFS_INODE_READDIO_NEED_LOCK - Re-incorporating write efficiency changes caused lockdep_assert() in iomap to be triggered, remove that code. Changes since v3 - Fixed freeze on generic/095. Use iomap_end() to account for failed/incomplete dio instead of btrfs_dio_data Changes since v4 - moved lockdep_assert_held() to functions calling iomap_dio_rw() This may be called immidiately after calling inode lock and may feel not required, but it seems important. - Removed comments which are no longer required - Changed commit comments to make them more appropriate Changes since v5 - restore inode_dio_wait() in truncate - Removed lockdep_assert_held() near callers Changes since v6 - Fixed hangs due to underlying device failures - Removed the patch to wait while releasing pages Changes since v7 - Moved reservation into btrfs iomap begin()/end() for correct reservation cleanup in case of device error. - Merged patches switch to iomap, and adding btrfs_iomap_end() for easier bisection. The switch to iomap would fail in case of dio after buffered writes.