mbox series

[v2,0/9] Cleanup metadata page reading path

Message ID 20200914093711.13523-1-nborisov@suse.com (mailing list archive)
Headers show
Series Cleanup metadata page reading path | expand

Message

Nikolay Borisov Sept. 14, 2020, 9:37 a.m. UTC
Here is v2 of the metadata readout cleanups [0]. This series incorporates the
feedback I received, namely:

* Added justification why removing btree_readpage is safe in Patch 1
* Dropped Patch 2 (pg_offset remove from btrfs_get_extent) as Qu intends on using
it in his subpage blocksize work.
* Add a comment about caller's responsibility for cleanup in Patch 3
* Added RB for patches which haven't changed since v1 and got RB by Josef.

[0] https://lore.kernel.org/linux-btrfs/20200909094914.29721-1-nborisov@suse.com/T/#t

Nikolay Borisov (9):
  btrfs: Remove btree_readpage
  btrfs: Simplify metadata pages reading
  btrfs: Remove btree_get_extent
  btrfs: Remove btrfs_get_extent indirection from __do_readpage
  btrfs: Remove mirror_num argument from extent_read_full_page
  btrfs: Promote extent_read_full_page to btrfs_readpage
  btrfs: Sink mirror_num argument in extent_read_full_page
  btrfs: Sink read_flags argument into extent_read_full_page
  btrfs: Sink mirror_num argument in __do_readpage

 fs/btrfs/disk-io.c   | 53 ---------------------------------
 fs/btrfs/disk-io.h   |  3 --
 fs/btrfs/extent_io.c | 71 +++++++++++++++-----------------------------
 fs/btrfs/extent_io.h |  6 ++--
 fs/btrfs/inode.c     |  9 +++++-
 5 files changed, 36 insertions(+), 106 deletions(-)

--
2.17.1

Comments

Johannes Thumshirn Sept. 14, 2020, 10:39 a.m. UTC | #1
On 14/09/2020 11:37, Nikolay Borisov wrote:
> Here is v2 of the metadata readout cleanups [0]. This series incorporates the
> feedback I received, namely:
> 
> * Added justification why removing btree_readpage is safe in Patch 1
> * Dropped Patch 2 (pg_offset remove from btrfs_get_extent) as Qu intends on using
> it in his subpage blocksize work.
> * Add a comment about caller's responsibility for cleanup in Patch 3
> * Added RB for patches which haven't changed since v1 and got RB by Josef.
> 
> [0] https://lore.kernel.org/linux-btrfs/20200909094914.29721-1-nborisov@suse.com/T/#t

Apart from the nit in 7/9
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Nikolay Borisov Sept. 14, 2020, 11:39 a.m. UTC | #2
On 14.09.20 г. 13:39 ч., Johannes Thumshirn wrote:
> On 14/09/2020 11:37, Nikolay Borisov wrote:
>> Here is v2 of the metadata readout cleanups [0]. This series incorporates the
>> feedback I received, namely:
>>
>> * Added justification why removing btree_readpage is safe in Patch 1
>> * Dropped Patch 2 (pg_offset remove from btrfs_get_extent) as Qu intends on using
>> it in his subpage blocksize work.
>> * Add a comment about caller's responsibility for cleanup in Patch 3
>> * Added RB for patches which haven't changed since v1 and got RB by Josef.
>>
>> [0] https://lore.kernel.org/linux-btrfs/20200909094914.29721-1-nborisov@suse.com/T/#t
> 
> Apart from the nit in 7/9
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> 


I believe your feedback has been addressed by the follow on patch I just
sent.
Johannes Thumshirn Sept. 14, 2020, 11:44 a.m. UTC | #3
On 14/09/2020 13:40, Nikolay Borisov wrote:
> I believe your feedback has been addressed by the follow on patch I just
> sent.
> 
Yep looks good, thanks :)
David Sterba Sept. 15, 2020, 7:43 a.m. UTC | #4
On Mon, Sep 14, 2020 at 12:37:02PM +0300, Nikolay Borisov wrote:
> Here is v2 of the metadata readout cleanups [0]. This series incorporates the
> feedback I received, namely:
> 
> * Added justification why removing btree_readpage is safe in Patch 1
> * Dropped Patch 2 (pg_offset remove from btrfs_get_extent) as Qu intends on using
> it in his subpage blocksize work.
> * Add a comment about caller's responsibility for cleanup in Patch 3
> * Added RB for patches which haven't changed since v1 and got RB by Josef.
> 
> [0] https://lore.kernel.org/linux-btrfs/20200909094914.29721-1-nborisov@suse.com/T/#t
> 
> Nikolay Borisov (9):
>   btrfs: Remove btree_readpage
>   btrfs: Simplify metadata pages reading
>   btrfs: Remove btree_get_extent
>   btrfs: Remove btrfs_get_extent indirection from __do_readpage
>   btrfs: Remove mirror_num argument from extent_read_full_page
>   btrfs: Promote extent_read_full_page to btrfs_readpage
>   btrfs: Sink mirror_num argument in extent_read_full_page
>   btrfs: Sink read_flags argument into extent_read_full_page
>   btrfs: Sink mirror_num argument in __do_readpage

Added to misc-next, thanks.