| Message ID | 20200914093711.13523-1-nborisov@suse.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Cleanup metadata page reading path | expand |
On 14/09/2020 11:37, Nikolay Borisov wrote: > Here is v2 of the metadata readout cleanups [0]. This series incorporates the > feedback I received, namely: > > * Added justification why removing btree_readpage is safe in Patch 1 > * Dropped Patch 2 (pg_offset remove from btrfs_get_extent) as Qu intends on using > it in his subpage blocksize work. > * Add a comment about caller's responsibility for cleanup in Patch 3 > * Added RB for patches which haven't changed since v1 and got RB by Josef. > > [0] https://lore.kernel.org/linux-btrfs/20200909094914.29721-1-nborisov@suse.com/T/#t Apart from the nit in 7/9 Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
On 14.09.20 г. 13:39 ч., Johannes Thumshirn wrote: > On 14/09/2020 11:37, Nikolay Borisov wrote: >> Here is v2 of the metadata readout cleanups [0]. This series incorporates the >> feedback I received, namely: >> >> * Added justification why removing btree_readpage is safe in Patch 1 >> * Dropped Patch 2 (pg_offset remove from btrfs_get_extent) as Qu intends on using >> it in his subpage blocksize work. >> * Add a comment about caller's responsibility for cleanup in Patch 3 >> * Added RB for patches which haven't changed since v1 and got RB by Josef. >> >> [0] https://lore.kernel.org/linux-btrfs/20200909094914.29721-1-nborisov@suse.com/T/#t > > Apart from the nit in 7/9 > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> > I believe your feedback has been addressed by the follow on patch I just sent.
On 14/09/2020 13:40, Nikolay Borisov wrote: > I believe your feedback has been addressed by the follow on patch I just > sent. > Yep looks good, thanks :)
On Mon, Sep 14, 2020 at 12:37:02PM +0300, Nikolay Borisov wrote: > Here is v2 of the metadata readout cleanups [0]. This series incorporates the > feedback I received, namely: > > * Added justification why removing btree_readpage is safe in Patch 1 > * Dropped Patch 2 (pg_offset remove from btrfs_get_extent) as Qu intends on using > it in his subpage blocksize work. > * Add a comment about caller's responsibility for cleanup in Patch 3 > * Added RB for patches which haven't changed since v1 and got RB by Josef. > > [0] https://lore.kernel.org/linux-btrfs/20200909094914.29721-1-nborisov@suse.com/T/#t > > Nikolay Borisov (9): > btrfs: Remove btree_readpage > btrfs: Simplify metadata pages reading > btrfs: Remove btree_get_extent > btrfs: Remove btrfs_get_extent indirection from __do_readpage > btrfs: Remove mirror_num argument from extent_read_full_page > btrfs: Promote extent_read_full_page to btrfs_readpage > btrfs: Sink mirror_num argument in extent_read_full_page > btrfs: Sink read_flags argument into extent_read_full_page > btrfs: Sink mirror_num argument in __do_readpage Added to misc-next, thanks.