[00/13] Make btrfs W=1 clean

Message

Nikolay Borisov Jan. 19, 2021, 12:26 p.m. UTC

Hello,

This patch series aims to fix all current warnings produced by compiling btrfs
with W=1. My hopes are with these additions W=1 can become a default build
options for btrfs. With this series applied misc-next currently produces 1
genuine warning for an unused variable:

fs/btrfs/zoned.c: In function ‘btrfs_sb_log_location_bdev’:
fs/btrfs/zoned.c:491:6: warning: variable ‘zone_size’ set but not used [-Wunused-but-set-variable]
  491 |  u64 zone_size;


But I haven't fixed it since it's part of the WIP zoned support.

Nikolay Borisov (13):
  btrfs: Document modified paramater of add_extent_mapping
  btrfs: Fix parameter description of btrfs_add_extent_mapping
  btrfs: Fix function description format
  btrfs: Fix paramter description in delayed-ref.c functions
  btrfs: Improve parameter description for __btrfs_write_out_cache
  btrfs: Document now parameter of peek_discard_list
  btrfs: Document fs_info in btrfs_rmap_block
  btrfs: Fix description format of fs_info parameter of
    btrfs_wait_on_delayed_iputs
  btrfs: Document btrfs_check_shared parameters
  btrfs: Fix parameter description of
    btrfs_inode_rsv_release/btrfs_delalloc_release_space
  btrfs: Fix parameter description in space-info.c
  btrfs: Fix parameter description for functions in extent_io.c
  lib/zstd: Convert constants to defines

 fs/btrfs/backref.c          |  6 ++++++
 fs/btrfs/block-group.c      |  1 +
 fs/btrfs/delalloc-space.c   |  7 ++++---
 fs/btrfs/delayed-ref.c      | 16 +++++++++-------
 fs/btrfs/discard.c          |  1 +
 fs/btrfs/extent_io.c        | 34 +++++++++++++++++-----------------
 fs/btrfs/extent_map.c       | 12 +++++++-----
 fs/btrfs/file-item.c        | 22 ++++++++++++++--------
 fs/btrfs/free-space-cache.c | 10 ++++++----
 fs/btrfs/inode.c            |  2 +-
 fs/btrfs/space-info.c       | 35 +++++++++++++++++------------------
 include/linux/zstd.h        |  8 ++++----
 12 files changed, 87 insertions(+), 67 deletions(-)

--
2.25.1

Comments

David Sterba Jan. 19, 2021, 10:39 p.m. UTC | #1

On Tue, Jan 19, 2021 at 02:26:36PM +0200, Nikolay Borisov wrote:
> Hello,
> 
> This patch series aims to fix all current warnings produced by compiling btrfs
> with W=1. My hopes are with these additions W=1 can become a default build
> options for btrfs.

Great, I like that, some of the warnigs get caught by the build bots but
we want them caught at development time.