mbox series

[0/3] btrfs-progs: cleanup related to btrfs super block

Message ID 20211021014020.482242-1-wqu@suse.com (mailing list archive)
Headers show
Series btrfs-progs: cleanup related to btrfs super block | expand

Message

Qu Wenruo Oct. 21, 2021, 1:40 a.m. UTC
This patchset mostly cleans up the mismatch between
BTRFS_SUPER_INFO_SIZE and sizeof(struct btrfs_super_block).

This cleanup itself is going to replace all the following snippets:

	u8 super_block_data[BTRFS_SUPER_INFO_SIZE];
	struct btrfs_super_block *sb;

	sb = (struct btrfs_super_block *)super_block_data;

With:

	struct btrfs_super_block sb;

Also since we're here, also cache csum_type and csum_size in fs_info,
just like what we did in the kernel.

Qu Wenruo (3):
  btrfs-progs: unify sizeof(struct btrfs_super_block) and
    BTRFS_SUPER_INFO_SIZE
  btrfs-progs: remove temporary buffer for super block
  btrfs-progs: cache csum_size and csum_type in btrfs_fs_info

 btrfs-corrupt-block.c       |  6 +--
 check/main.c                |  6 +--
 check/mode-common.c         |  2 +-
 cmds/filesystem-usage.c     |  8 ++--
 cmds/inspect-dump-super.c   | 11 ++----
 cmds/rescue-chunk-recover.c | 24 ++++++-----
 cmds/rescue-super-recover.c | 11 +++---
 common/device-scan.c        | 23 ++++-------
 common/utils.c              |  8 ++--
 convert/common.c            | 79 +++++++++++++++++--------------------
 convert/main.c              | 29 ++++++--------
 image/main.c                | 14 +++----
 kernel-shared/ctree.h       |  9 +++++
 kernel-shared/disk-io.c     | 41 +++++++++----------
 kernel-shared/disk-io.h     |  3 --
 kernel-shared/file-item.c   | 15 +++----
 kernel-shared/print-tree.c  |  4 +-
 kernel-shared/volumes.c     | 14 +++----
 mkfs/common.c               |  8 ++--
 19 files changed, 141 insertions(+), 174 deletions(-)

Comments

David Sterba Nov. 4, 2021, 7:10 p.m. UTC | #1
On Thu, Oct 21, 2021 at 09:40:17AM +0800, Qu Wenruo wrote:
> This patchset mostly cleans up the mismatch between
> BTRFS_SUPER_INFO_SIZE and sizeof(struct btrfs_super_block).
> 
> This cleanup itself is going to replace all the following snippets:
> 
> 	u8 super_block_data[BTRFS_SUPER_INFO_SIZE];
> 	struct btrfs_super_block *sb;
> 
> 	sb = (struct btrfs_super_block *)super_block_data;
> 
> With:
> 
> 	struct btrfs_super_block sb;
> 
> Also since we're here, also cache csum_type and csum_size in fs_info,
> just like what we did in the kernel.
> 
> Qu Wenruo (3):
>   btrfs-progs: unify sizeof(struct btrfs_super_block) and
>     BTRFS_SUPER_INFO_SIZE
>   btrfs-progs: remove temporary buffer for super block
>   btrfs-progs: cache csum_size and csum_type in btrfs_fs_info

Added to devel, thanks, the removal of temporary buffer for superblock
is nice.