| Message ID | 20220218073156.2179803-1-shinichiro.kawasaki@wdc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | fstests: fix _scratch_mkfs_sized failure handling | expand |
On Fri, Feb 18, 2022 at 04:31:50PM +0900, Shin'ichiro Kawasaki wrote: > When generic/204 is run for btrfs-zoned filesystem on zoned block devices with > GB size order, it takes very long time to complete. The test case creates 115MiB > filesystem on the scratch device and fills files in it within decent run time. > However, with btrfs-zoned condition, the test case creates filesystem as large > as the device size and it takes very long time to fill it all. Three causes were > identified for the long run time, and this series addresses them. > > The first cause is mixed mode option that _scratch_mkfs_sized helper function > adds to mkfs.btrfs. This option was added for both regular btrfs and > zoned-btrfs. However, zoned-btrfs does not support mixed mode. The mkfs with > mixed mode fails and results in _scratch_mkfs_sized failure. The mixed mode > shall not be specified for btrfs-zoned filesystem. > > The second cause is unnecessary call of the _scratch_mkfs helper function in the > test case generic/204. This helper function is called to obtain data block size > and i-node size. However, these numbers can be obtained from _scratch_mkfs_sized > call. The _scratch_mkfs function call shall be removed. > > The third cause is no check of return code from _scratch_mkfs_sized. The test > case generic/204 calls both _scratch_mkfs and _scratch_mkfs_sized, and does not > check return code from them. If _scratch_mkfs succeeds and _scratch_mkfs_sized > fails, the scratch device still has valid filesystem created by _scratch_mkfs. > Following test workload can be executed without failure, but the filesystem > does not have the size specified for _scratch_mkfs_sized. The return code of > _scratch_mkfs_sized shall be checked to catch the mkfs failure. This problem > exists not only in generic/204, but also in other test cases which call both > _scratch_mkfs and _scratch_mkfs_sized. > > In this series, the first patch addresses the first cause, and the second patch > addresses the second cause. These two patches fix the test case generic/204. > Following three patches address the third cause, and fix other test cases than > generic/204. > > The last patch is an additional clean up of the helper function _filter_mkfs. > During this fix work, it was misunderstood that this function were xfs unique. > To clarify it can be extended to other filesystems, factor out xfs unique part. > > Changes from v2: > * Added Reviewed-by tags > > Changes from v1: > * Added 2nd patch which removes _scratch_mkfs call from generic/204 > * Added 6th patch which factors out xfs unique part from _filter_mkfs > * Dropped 3 patches which had renamed _filter_mkfs to _xfs_filter_mkfs > * Dropped generic/204 hunk from the 3rd patch > > Shin'ichiro Kawasaki (6): > common/rc: fix btrfs mixed mode usage in _scratch_mkfs_sized > generic/204: remove unnecessary _scratch_mkfs call > generic/{171,172,173,174}: check _scratch_mkfs_sized return code > ext4/021: check _scratch_mkfs_sized return code > xfs/015: check _scratch_mkfs_sized return code > common: factor out xfs unique part from _filter_mkfs Thanks a lot for all the changes! I've applied all patches except the first one. Also many thanks to Darrick for reviewing them! Thanks, Eryu > > common/filter | 40 +--------------------------------------- > common/rc | 8 ++++---- > common/xfs | 41 +++++++++++++++++++++++++++++++++++++++++ > tests/ext4/021 | 2 +- > tests/generic/171 | 2 +- > tests/generic/172 | 2 +- > tests/generic/173 | 2 +- > tests/generic/174 | 2 +- > tests/generic/204 | 6 +----- > tests/xfs/015 | 2 +- > 10 files changed, 53 insertions(+), 54 deletions(-) > > -- > 2.34.1
When generic/204 is run for btrfs-zoned filesystem on zoned block devices with GB size order, it takes very long time to complete. The test case creates 115MiB filesystem on the scratch device and fills files in it within decent run time. However, with btrfs-zoned condition, the test case creates filesystem as large as the device size and it takes very long time to fill it all. Three causes were identified for the long run time, and this series addresses them. The first cause is mixed mode option that _scratch_mkfs_sized helper function adds to mkfs.btrfs. This option was added for both regular btrfs and zoned-btrfs. However, zoned-btrfs does not support mixed mode. The mkfs with mixed mode fails and results in _scratch_mkfs_sized failure. The mixed mode shall not be specified for btrfs-zoned filesystem. The second cause is unnecessary call of the _scratch_mkfs helper function in the test case generic/204. This helper function is called to obtain data block size and i-node size. However, these numbers can be obtained from _scratch_mkfs_sized call. The _scratch_mkfs function call shall be removed. The third cause is no check of return code from _scratch_mkfs_sized. The test case generic/204 calls both _scratch_mkfs and _scratch_mkfs_sized, and does not check return code from them. If _scratch_mkfs succeeds and _scratch_mkfs_sized fails, the scratch device still has valid filesystem created by _scratch_mkfs. Following test workload can be executed without failure, but the filesystem does not have the size specified for _scratch_mkfs_sized. The return code of _scratch_mkfs_sized shall be checked to catch the mkfs failure. This problem exists not only in generic/204, but also in other test cases which call both _scratch_mkfs and _scratch_mkfs_sized. In this series, the first patch addresses the first cause, and the second patch addresses the second cause. These two patches fix the test case generic/204. Following three patches address the third cause, and fix other test cases than generic/204. The last patch is an additional clean up of the helper function _filter_mkfs. During this fix work, it was misunderstood that this function were xfs unique. To clarify it can be extended to other filesystems, factor out xfs unique part. Changes from v2: * Added Reviewed-by tags Changes from v1: * Added 2nd patch which removes _scratch_mkfs call from generic/204 * Added 6th patch which factors out xfs unique part from _filter_mkfs * Dropped 3 patches which had renamed _filter_mkfs to _xfs_filter_mkfs * Dropped generic/204 hunk from the 3rd patch Shin'ichiro Kawasaki (6): common/rc: fix btrfs mixed mode usage in _scratch_mkfs_sized generic/204: remove unnecessary _scratch_mkfs call generic/{171,172,173,174}: check _scratch_mkfs_sized return code ext4/021: check _scratch_mkfs_sized return code xfs/015: check _scratch_mkfs_sized return code common: factor out xfs unique part from _filter_mkfs common/filter | 40 +--------------------------------------- common/rc | 8 ++++---- common/xfs | 41 +++++++++++++++++++++++++++++++++++++++++ tests/ext4/021 | 2 +- tests/generic/171 | 2 +- tests/generic/172 | 2 +- tests/generic/173 | 2 +- tests/generic/174 | 2 +- tests/generic/204 | 6 +----- tests/xfs/015 | 2 +- 10 files changed, 53 insertions(+), 54 deletions(-)