mbox series

[0/5] Misc warning fixes

Message ID cover.1597666167.git.dsterba@suse.com (mailing list archive)
Headers show
Series Misc warning fixes | expand

Message

David Sterba Aug. 17, 2020, 12:11 p.m. UTC 
Compiling with W=1 or W=2 gives warnings that seem to be worth fixing.

David Sterba (5):
  btrfs: remove const from btrfs_feature_set_name
  btrfs: compression: move declarations to header
  btrfs: remove unnecessarily shadowed variables
  btrfs: scrub: rename ratelimit state varaible to avoid shadowing
  btrfs: send: remove indirect callback parameter for changed_cb

 fs/btrfs/backref.c     |  1 -
 fs/btrfs/compression.c | 35 -----------------------------------
 fs/btrfs/compression.h | 35 +++++++++++++++++++++++++++++++++++
 fs/btrfs/inode.c       |  1 -
 fs/btrfs/scrub.c       |  8 ++++----
 fs/btrfs/send.c        | 11 ++---------
 fs/btrfs/sysfs.c       |  2 +-
 fs/btrfs/sysfs.h       |  2 +-
 8 files changed, 43 insertions(+), 52 deletions(-)

Comments

Josef Bacik Aug. 18, 2020, 3:38 p.m. UTC | #1 
On 8/17/20 8:11 AM, David Sterba wrote:
> Compiling with W=1 or W=2 gives warnings that seem to be worth fixing.
> 
> David Sterba (5):
>    btrfs: remove const from btrfs_feature_set_name
>    btrfs: compression: move declarations to header
>    btrfs: remove unnecessarily shadowed variables
>    btrfs: scrub: rename ratelimit state varaible to avoid shadowing
>    btrfs: send: remove indirect callback parameter for changed_cb
> 
>   fs/btrfs/backref.c     |  1 -
>   fs/btrfs/compression.c | 35 -----------------------------------
>   fs/btrfs/compression.h | 35 +++++++++++++++++++++++++++++++++++
>   fs/btrfs/inode.c       |  1 -
>   fs/btrfs/scrub.c       |  8 ++++----
>   fs/btrfs/send.c        | 11 ++---------
>   fs/btrfs/sysfs.c       |  2 +-
>   fs/btrfs/sysfs.h       |  2 +-
>   8 files changed, 43 insertions(+), 52 deletions(-)
> 

The whole series can have

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef