Message ID | cover.1615580595.git.josef@toxicpanda.com (mailing list archive) |
---|---|
Headers | show
Return-Path: <linux-btrfs-owner@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F722C433DB for <linux-btrfs@archiver.kernel.org>; Fri, 12 Mar 2021 20:26:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7F9364F9E for <linux-btrfs@archiver.kernel.org>; Fri, 12 Mar 2021 20:26:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234759AbhCLU0F (ORCPT <rfc822;linux-btrfs@archiver.kernel.org>); Fri, 12 Mar 2021 15:26:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234781AbhCLUZh (ORCPT <rfc822;linux-btrfs@vger.kernel.org>); Fri, 12 Mar 2021 15:25:37 -0500 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 711F6C061761 for <linux-btrfs@vger.kernel.org>; Fri, 12 Mar 2021 12:25:37 -0800 (PST) Received: by mail-qk1-x72d.google.com with SMTP id g185so25701058qkf.6 for <linux-btrfs@vger.kernel.org>; Fri, 12 Mar 2021 12:25:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=mNCIUetdIhwmDFpunjhFkEGTRdJ7QjL1tQLfeNxoNZY=; b=x70K7o0/RyPsisUsS27e/pXJBCrnrg6nimOIOYLFNkxmr5TRwsDuybNBj25V6pWtIf 4NMYcrczjsxqW0t+SCcWeblws12iCCk6n1ybfW+q+TUIuRZxOr4U+4LjbBq2CJhftz2E SyeCsDND2mEl5ToQ52xBsHcd8bByj3eClRXTxSsG+kEm7gVz4kvCo81IMBxFdWVhD3Im +EtrLVtAOVYywBZZX0RBbnEF/dBcnJeFtxLazQON5fL8oAolYNk5IbF+jfmo3xBpjeZr HcVhKpsOyNbwAq9Rol6HteL5D5MxM6HX9m7MxsD1tjauCnLgr51XcFr6DXB1sw7KKtGs pBRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=mNCIUetdIhwmDFpunjhFkEGTRdJ7QjL1tQLfeNxoNZY=; b=rPNSyBi2NzstsdbZnlfDy/+5QA7xqA7oE6RT99kWxzEYbnOg9OwY1utEoqssxsWiZ+ JVb4C6Kc9A2AmzR8dKhjG+uwg6Va2IHq4PXB4cMrjnmXkoJ8oShYJOXSqOi2hYJ5zHEr wNhp3Yh3b65k+AZ27Um52uG8odsWuVewOA7tG4ZL0z4HW9sOte9+ETHCkM8WilfB0/KM 811H9j9fIKxlDre0rMxXFhg/VAVfs4G7n/KIL84MG+mx3VEFFbhUmD9NDEu8y6kbbyw9 cmYxCKZfHrh68L5+fcFOI824ryRm/5zZXtZVcHRocXQnpjTV5PDV0mSvk1A1bBuGfZbj jQMQ== X-Gm-Message-State: AOAM533hImFnc3KwlxJqfx/ij/lz8CX+BeDy8slsUxJpOJpV3/4EKl2M TlJkTiJWeBV2Omm3/OuTvb8AZHBAxXaluEij X-Google-Smtp-Source: ABdhPJxS7k4gkQ7TaDsyej7M6n73CYirH6+GzrYmXPgkPUgX3+BRrrPrus5RIHu0w+1yh8y8dIWmIw== X-Received: by 2002:ae9:e518:: with SMTP id w24mr2036308qkf.78.1615580736269; Fri, 12 Mar 2021 12:25:36 -0800 (PST) Received: from localhost (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id g21sm5316443qkk.72.2021.03.12.12.25.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Mar 2021 12:25:35 -0800 (PST) From: Josef Bacik <josef@toxicpanda.com> To: linux-btrfs@vger.kernel.org, kernel-team@fb.com Subject: [PATCH v8 00/39] Cleanup error handling in relocation Date: Fri, 12 Mar 2021 15:24:55 -0500 Message-Id: <cover.1615580595.git.josef@toxicpanda.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: <linux-btrfs.vger.kernel.org> X-Mailing-List: linux-btrfs@vger.kernel.org |
Series |
Cleanup error handling in relocation
|
expand
|
On Fri, Mar 12, 2021 at 03:24:55PM -0500, Josef Bacik wrote: > v7->v8: > - Reordered some of the patches, so that the callers of functions that added new > error cases were fixed first, and then added the new error handler. > - Moved a few of the ASSERT(0) to where they made sense. Left the others that > are in functions that can have multiple cases of the same error that indicates > a logic error. With some updates in changelogs and comments moved from topic branch to misc-next. I'm still not happy about the ASSERT(0), it should be a real error or a real assert. We can't observe the same behaviour with asserts enabled and disabled.