mbox series

[0/2] Profile mask and calculation cleanups

Message ID cover.1655996117.git.dsterba@suse.com (mailing list archive)
Headers show
Series Profile mask and calculation cleanups | expand

Message

David Sterba June 23, 2022, 2:56 p.m. UTC
There are still some instances of hardcoded values repeating what we
have in the raid attr table or using a similar expresion to calculate
things that can be simplified.

David Sterba (2):
  btrfs: use mask for all RAID1* profiles in btrfs_calc_avail_data_space
  btrfs: merge calculations for simple striped profiles in
    btrfs_rmap_block

 fs/btrfs/block-group.c | 5 ++---
 fs/btrfs/super.c       | 8 ++------
 2 files changed, 4 insertions(+), 9 deletions(-)

Comments

Nikolay Borisov June 23, 2022, 3:31 p.m. UTC | #1
On 23.06.22 г. 17:56 ч., David Sterba wrote:
> There are still some instances of hardcoded values repeating what we
> have in the raid attr table or using a similar expresion to calculate
> things that can be simplified.
> 
> David Sterba (2):
>    btrfs: use mask for all RAID1* profiles in btrfs_calc_avail_data_space
>    btrfs: merge calculations for simple striped profiles in
>      btrfs_rmap_block
> 
>   fs/btrfs/block-group.c | 5 ++---
>   fs/btrfs/super.c       | 8 ++------
>   2 files changed, 4 insertions(+), 9 deletions(-)
> 

Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Johannes Thumshirn June 24, 2022, 6:41 a.m. UTC | #2
On 23.06.22 17:01, David Sterba wrote:
> There are still some instances of hardcoded values repeating what we
> have in the raid attr table or using a similar expresion to calculate
> things that can be simplified.
> 
> David Sterba (2):
>   btrfs: use mask for all RAID1* profiles in btrfs_calc_avail_data_space
>   btrfs: merge calculations for simple striped profiles in
>     btrfs_rmap_block
> 
>  fs/btrfs/block-group.c | 5 ++---
>  fs/btrfs/super.c       | 8 ++------
>  2 files changed, 4 insertions(+), 9 deletions(-)
> 
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
David Sterba June 24, 2022, 1:42 p.m. UTC | #3
On Thu, Jun 23, 2022 at 04:56:58PM +0200, David Sterba wrote:
> There are still some instances of hardcoded values repeating what we
> have in the raid attr table or using a similar expresion to calculate
> things that can be simplified.
> 
> David Sterba (2):
>   btrfs: use mask for all RAID1* profiles in btrfs_calc_avail_data_space
>   btrfs: merge calculations for simple striped profiles in
>     btrfs_rmap_block

Added to misc-next.