mbox series

[v2,0/3] Cleanup short int types in block group reserve

Message ID cover.1657220460.git.dsterba@suse.com (mailing list archive)
Headers show
Series Cleanup short int types in block group reserve | expand

Message

David Sterba July 7, 2022, 7:02 p.m. UTC 
Using the short type in btrfs_block_rsv is not needed for bool
indicators and we can make the structure smaller.

v2:
- fix true/false typo in first patch
- use named enum for block group type

David Sterba (3):
  btrfs: switch btrfs_block_rsv::full to bool
  btrfs: switch btrfs_block_rsv::failfast to bool
  btrfs: use enum for btrfs_block_rsv::type

 fs/btrfs/block-rsv.c   | 21 +++++++++------------
 fs/btrfs/block-rsv.h   | 15 ++++++++-------
 fs/btrfs/delayed-ref.c |  4 ++--
 fs/btrfs/file.c        |  2 +-
 fs/btrfs/inode.c       |  4 ++--
 5 files changed, 22 insertions(+), 24 deletions(-)

Comments

Anand Jain July 8, 2022, 1:21 p.m. UTC | #1 
On 08/07/2022 03:02, David Sterba wrote:
> Using the short type in btrfs_block_rsv is not needed for bool
> indicators and we can make the structure smaller.
> 
> v2:
> - fix true/false typo in first patch
> - use named enum for block group type
> 
> David Sterba (3):
>    btrfs: switch btrfs_block_rsv::full to bool
>    btrfs: switch btrfs_block_rsv::failfast to bool
>    btrfs: use enum for btrfs_block_rsv::type
> 
>   fs/btrfs/block-rsv.c   | 21 +++++++++------------
>   fs/btrfs/block-rsv.h   | 15 ++++++++-------
>   fs/btrfs/delayed-ref.c |  4 ++--
>   fs/btrfs/file.c        |  2 +-
>   fs/btrfs/inode.c       |  4 ++--
>   5 files changed, 22 insertions(+), 24 deletions(-)
> 

For the whole series

Reviewed-by: Anand Jain <anand.jain@oracle.com>
Johannes Thumshirn July 9, 2022, 11:40 a.m. UTC | #2 
On 07.07.22 21:08, David Sterba wrote:
> Using the short type in btrfs_block_rsv is not needed for bool
> indicators and we can make the structure smaller.
> 
> v2:
> - fix true/false typo in first patch
> - use named enum for block group type
> 
> David Sterba (3):
>   btrfs: switch btrfs_block_rsv::full to bool
>   btrfs: switch btrfs_block_rsv::failfast to bool
>   btrfs: use enum for btrfs_block_rsv::type
> 
>  fs/btrfs/block-rsv.c   | 21 +++++++++------------
>  fs/btrfs/block-rsv.h   | 15 ++++++++-------
>  fs/btrfs/delayed-ref.c |  4 ++--
>  fs/btrfs/file.c        |  2 +-
>  fs/btrfs/inode.c       |  4 ++--
>  5 files changed, 22 insertions(+), 24 deletions(-)
> 

Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>