| Message ID | cover.1662636489.git.fdmanana@suse.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | btrfs: fix a couple of hangs during unmount caused by races | expand |
On Thu, Sep 08, 2022 at 12:31:49PM +0100, fdmanana@kernel.org wrote: > From: Filipe Manana <fdmanana@suse.com> > > Due to some races or bad timmings, we can hang during unmount when trying > to stop the block group reclaim task or one of the space reclaim tasks. > The second case if often triggered by generic/562 for a while, but the > underlying problem has been there for a long time, despite seeming to be > more frequent recently. More details in the changelogs. > You can add Reviewed-by: Josef Bacik <josef@toxicpanda.com> to the entire series, thanks, Josef
On Thu, Sep 08, 2022 at 12:31:49PM +0100, fdmanana@kernel.org wrote: > From: Filipe Manana <fdmanana@suse.com> > > Due to some races or bad timmings, we can hang during unmount when trying > to stop the block group reclaim task or one of the space reclaim tasks. > The second case if often triggered by generic/562 for a while, but the > underlying problem has been there for a long time, despite seeming to be > more frequent recently. More details in the changelogs. > > Filipe Manana (3): > btrfs: fix hang during unmount when stopping block group reclaim worker > btrfs: fix hang during unmount when stopping a space reclaim worker > btrfs: remove useless used space increment during space reservation Added to for-next, thanks.
On Fri, Sep 09, 2022 at 04:32:54PM +0200, David Sterba wrote: > On Thu, Sep 08, 2022 at 12:31:49PM +0100, fdmanana@kernel.org wrote: > > From: Filipe Manana <fdmanana@suse.com> > > > > Due to some races or bad timmings, we can hang during unmount when trying > > to stop the block group reclaim task or one of the space reclaim tasks. > > The second case if often triggered by generic/562 for a while, but the > > underlying problem has been there for a long time, despite seeming to be > > more frequent recently. More details in the changelogs. > > > > Filipe Manana (3): > > btrfs: fix hang during unmount when stopping block group reclaim worker > > btrfs: fix hang during unmount when stopping a space reclaim worker > > btrfs: remove useless used space increment during space reservation > > Added to for-next, thanks. Moved to misc-next, thanks.
From: Filipe Manana <fdmanana@suse.com> Due to some races or bad timmings, we can hang during unmount when trying to stop the block group reclaim task or one of the space reclaim tasks. The second case if often triggered by generic/562 for a while, but the underlying problem has been there for a long time, despite seeming to be more frequent recently. More details in the changelogs. Filipe Manana (3): btrfs: fix hang during unmount when stopping block group reclaim worker btrfs: fix hang during unmount when stopping a space reclaim worker btrfs: remove useless used space increment during space reservation fs/btrfs/disk-io.c | 42 ++++++++++++++++++++++++++++++++++++------ fs/btrfs/space-info.c | 1 - 2 files changed, 36 insertions(+), 7 deletions(-)