mbox series

[0/2] btrfs-progs: receive: address setattr failures

Message ID cover.1667494221.git.fdmanana@suse.com (mailing list archive)
Headers show
Series btrfs-progs: receive: address setattr failures | expand

Message

Filipe Manana Nov. 3, 2022, 4:53 p.m. UTC
From: Filipe Manana <fdmanana@suse.com>

I was writing a test case for fstests with fsstress and send v2 streams
and it turns out that receive will always fail if we have a fileattr
command in the stream. It fails for two different reasons, described in
the changelog.

We actually had a report today of a receiver failing on a send stream v2
because of the reason addressed in the first patch. However fixing that
alone, will still cause the receiver to fail, just for a different reason
(patch 2).

For now I'll hold the test case for fstests since it fails very frequently
(almost always actually).

Filipe Manana (2):
  btrfs-progs: receive: fix parsing of attributes field from the fileattr command
  btrfs-progs: receive: work around failure of fileattr commands

 cmds/receive.c       | 44 ++++++++++++++++++++++++++------------------
 common/send-stream.c |  2 +-
 2 files changed, 27 insertions(+), 19 deletions(-)

Comments

David Sterba Nov. 11, 2022, 3:36 p.m. UTC | #1
On Thu, Nov 03, 2022 at 04:53:25PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> I was writing a test case for fstests with fsstress and send v2 streams
> and it turns out that receive will always fail if we have a fileattr
> command in the stream. It fails for two different reasons, described in
> the changelog.
> 
> We actually had a report today of a receiver failing on a send stream v2
> because of the reason addressed in the first patch. However fixing that
> alone, will still cause the receiver to fail, just for a different reason
> (patch 2).
> 
> For now I'll hold the test case for fstests since it fails very frequently
> (almost always actually).
> 
> Filipe Manana (2):
>   btrfs-progs: receive: fix parsing of attributes field from the fileattr command
>   btrfs-progs: receive: work around failure of fileattr commands

Added to devel, thanks.