[v2,0/7] btrfs-progs: fix -Wmissing-prototypes warnings and enable that warning option

Message

Qu Wenruo May 3, 2023, 6:03 a.m. UTC

We have at least one case that some function is exported but never got
utilized in the first place.

Let's prevent this problem from happening again by enable
-Wmissing-prototypes to debug builds at least.

Fixes for  the existing warnings are split into several patches:

- Remove unused functions
  Two patches, the first is to remove a function that never got
  utilized from the introduction.

  The second is to remove a very old feature (only for <3.12 kernels)
  in libbtrfs.
  In fact this functionality for fs without an UUID tree is already
  broken during previous cleanups.
  (Need to export subvol_uuid_search_add() and
   subvol_uuid_search_finit(), as it's callers' responsibility to
   search for the target subvolume by themselves)

  And since no one is complaining ever since, there is really no need
  to maintain such an old and deprecated feature in libbtrfs.

- Fixes for crypto related function
  Two patches, one for each csum algo (blake2 and sha256).
  Involves extra declarations in the headers.

- Trivial fixes
  Mostly unexport and add needed headers.

Qu Wenruo (7):
  btrfs-progs: remove function btrfs_check_allocatable_zones()
  btrfs-progs: libbtrfs: remove the support for fs without uuid tree
  btrfs-progs: crypto/blake2: remove blake2 simple API
  btrfs-progs: crypto/blake2: move optimized declarations to blake2b.h
  btrfs-progs: crypto/sha: declare the x86 optimized implementation
  btrfs-progs: fix -Wmissing-prototypes warnings
  btrfs-progs: Makefile: enable -Wmissing-prototypes

 Makefile              |   3 +-
 cmds/qgroup.c         |   2 +-
 cmds/reflink.c        |   2 +-
 cmds/subvolume-list.c |   2 +-
 common/device-utils.c |   2 +-
 common/utils.c        |   2 +-
 crypto/blake2.h       |   5 +
 crypto/blake2b-ref.c  |   8 -
 crypto/sha.h          |   3 +
 crypto/sha256-x86.c   |   2 +
 kernel-shared/ulist.c |   2 +-
 kernel-shared/zoned.c |  60 +------
 libbtrfs/send-utils.c | 396 ------------------------------------------
 libbtrfs/send-utils.h |  20 ---
 tune/change-csum.c    |   1 +
 tune/change-uuid.c    |   1 +
 tune/convert-bgt.c    |   1 +
 tune/seeding.c        |   1 +
 tune/tune.h           |   2 +
 19 files changed, 25 insertions(+), 490 deletions(-)

Comments

David Sterba May 4, 2023, 10:18 p.m. UTC | #1

On Wed, May 03, 2023 at 02:03:36PM +0800, Qu Wenruo wrote:
> We have at least one case that some function is exported but never got
> utilized in the first place.
> 
> Let's prevent this problem from happening again by enable
> -Wmissing-prototypes to debug builds at least.
> 
> Fixes for  the existing warnings are split into several patches:
> 
> - Remove unused functions
>   Two patches, the first is to remove a function that never got
>   utilized from the introduction.
> 
>   The second is to remove a very old feature (only for <3.12 kernels)
>   in libbtrfs.
>   In fact this functionality for fs without an UUID tree is already
>   broken during previous cleanups.
>   (Need to export subvol_uuid_search_add() and
>    subvol_uuid_search_finit(), as it's callers' responsibility to
>    search for the target subvolume by themselves)
> 
>   And since no one is complaining ever since, there is really no need
>   to maintain such an old and deprecated feature in libbtrfs.
> 
> - Fixes for crypto related function
>   Two patches, one for each csum algo (blake2 and sha256).
>   Involves extra declarations in the headers.
> 
> - Trivial fixes
>   Mostly unexport and add needed headers.
> 
> Qu Wenruo (7):
>   btrfs-progs: remove function btrfs_check_allocatable_zones()
>   btrfs-progs: libbtrfs: remove the support for fs without uuid tree
>   btrfs-progs: crypto/blake2: remove blake2 simple API
>   btrfs-progs: crypto/blake2: move optimized declarations to blake2b.h
>   btrfs-progs: crypto/sha: declare the x86 optimized implementation
>   btrfs-progs: fix -Wmissing-prototypes warnings
>   btrfs-progs: Makefile: enable -Wmissing-prototypes

Added to devel, thanks.