mbox series

[v2,0/3] btrfs: updates to error path for delayed dir index insertion failure

Message ID cover.1693209858.git.fdmanana@suse.com (mailing list archive)
Headers show
Series btrfs: updates to error path for delayed dir index insertion failure | expand

Message

Filipe Manana Aug. 28, 2023, 8:06 a.m. UTC
From: Filipe Manana <fdmanana@suse.com>

Some updates to the error path for delayed dir index insertion failure,
motivated by a recent syzbot report:

  https://lore.kernel.org/linux-btrfs/00000000000036e1290603e097e0@google.com/

Details in the changelogs.

v2: Fixed error path in patch 2 to release delayed item before unlocking
    the delayed node. Added patch 3 to prevent such mistakes in the future.

Filipe Manana (3):
  btrfs: improve error message after failure to add delayed dir index item
  btrfs: remove BUG() after failure to insert delayed dir index item
  btrfs: assert delayed node locked when removing delayed item

 fs/btrfs/delayed-inode.c | 85 ++++++++++++++++++++++++++--------------
 1 file changed, 55 insertions(+), 30 deletions(-)

Comments

David Sterba Sept. 5, 2023, 12:38 p.m. UTC | #1
On Mon, Aug 28, 2023 at 09:06:41AM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Some updates to the error path for delayed dir index insertion failure,
> motivated by a recent syzbot report:
> 
>   https://lore.kernel.org/linux-btrfs/00000000000036e1290603e097e0@google.com/
> 
> Details in the changelogs.
> 
> v2: Fixed error path in patch 2 to release delayed item before unlocking
>     the delayed node. Added patch 3 to prevent such mistakes in the future.
> 
> Filipe Manana (3):
>   btrfs: improve error message after failure to add delayed dir index item
>   btrfs: remove BUG() after failure to insert delayed dir index item
>   btrfs: assert delayed node locked when removing delayed item

Added to misc-next, thanks.