[0/2,v2] btrfs-progs: mkfs: testing cloned-device

Message

Anand Jain Oct. 3, 2023, 3:46 a.m. UTC

v2:
Worked on review comments from David.

--- v1 ---
This patchset adds support for testing cloned-device in mkfs.
So using mkfs.btrfs both option -U and -P a new device can be created
to match the FSID and UUID of an existing device. This is useful for
testing cloned-device.

Anand Jain (2):
  btrfs-progs: document allowing duplicate fsid
  btrfs-progs: add mkfs option for dev_uuid

 Documentation/mkfs.btrfs.rst | 10 ++++++++--
 mkfs/common.c                |  8 +++++++-
 mkfs/common.h                |  5 +++++
 mkfs/main.c                  | 16 +++++++++++++++-
 4 files changed, 35 insertions(+), 4 deletions(-)

Comments

David Sterba Oct. 17, 2023, 11:49 p.m. UTC | #1

On Tue, Oct 03, 2023 at 11:46:12AM +0800, Anand Jain wrote:
> v2:
> Worked on review comments from David.
> 
> --- v1 ---
> This patchset adds support for testing cloned-device in mkfs.
> So using mkfs.btrfs both option -U and -P a new device can be created
> to match the FSID and UUID of an existing device. This is useful for
> testing cloned-device.
> 
> Anand Jain (2):
>   btrfs-progs: document allowing duplicate fsid
>   btrfs-progs: add mkfs option for dev_uuid

Added to devel, thanks. I did some fixups, the device uuid is printed in
the summary and validation of the device uuid.

Anand Jain Oct. 19, 2023, 1:32 a.m. UTC | #2

On 10/18/23 05:19, David Sterba wrote:
> On Tue, Oct 03, 2023 at 11:46:12AM +0800, Anand Jain wrote:
>> v2:
>> Worked on review comments from David.
>>
>> --- v1 ---
>> This patchset adds support for testing cloned-device in mkfs.
>> So using mkfs.btrfs both option -U and -P a new device can be created
>> to match the FSID and UUID of an existing device. This is useful for
>> testing cloned-device.
>>
>> Anand Jain (2):
>>    btrfs-progs: document allowing duplicate fsid



+        must not already exist on any currently present filesystem.


There is a white-space error at the end of the line mentioned above in 
the devel branch.

>>    btrfs-progs: add mkfs option for dev_uuid
> 
> Added to devel, thanks. I did some fixups, the device uuid is printed in
> the summary and validation of the device uuid.

Looks good. Thanks.

- Anand

David Sterba Oct. 19, 2023, 11:59 a.m. UTC | #3

On Thu, Oct 19, 2023 at 07:02:45AM +0530, Anand Jain wrote:
> 
> 
> On 10/18/23 05:19, David Sterba wrote:
> > On Tue, Oct 03, 2023 at 11:46:12AM +0800, Anand Jain wrote:
> >> v2:
> >> Worked on review comments from David.
> >>
> >> --- v1 ---
> >> This patchset adds support for testing cloned-device in mkfs.
> >> So using mkfs.btrfs both option -U and -P a new device can be created
> >> to match the FSID and UUID of an existing device. This is useful for
> >> testing cloned-device.
> >>
> >> Anand Jain (2):
> >>    btrfs-progs: document allowing duplicate fsid
> 
> 
> 
> +        must not already exist on any currently present filesystem.

Fixed.