mbox series

[0/6] btrfs: fix some data races during fsync and cleanups

Message ID cover.1696415673.git.fdmanana@suse.com (mailing list archive)
Headers show
Series btrfs: fix some data races during fsync and cleanups | expand

Message

Filipe Manana Oct. 4, 2023, 10:38 a.m. UTC
From: Filipe Manana <fdmanana@suse.com>

The following remove some data races affecting mostly fsync. In general
these are mostly harmless from a functional perspective, though there are
a few cases that could cause some unexpected results but should be very
rare to hit. There's also a couple cleanups here.
More details on the changelogs.

Filipe Manana (6):
  btrfs: add and use helpers for reading and writing last_log_commit
  btrfs: add and use helpers for reading and writing log_transid
  btrfs: add and use helpers for reading and writing fs_info->generation
  btrfs: add and use helpers for reading and writing last_trans_committed
  btrfs: remove pointless barrier from btrfs_sync_file()
  btrfs: update comment for struct btrfs_inode::lock

 fs/btrfs/btrfs_inode.h  | 34 +++++++++++++++++++---------------
 fs/btrfs/ctree.h        | 34 +++++++++++++++++++++++++++++++++-
 fs/btrfs/disk-io.c      | 17 +++++++++--------
 fs/btrfs/file.c         |  5 ++---
 fs/btrfs/fs.h           | 30 ++++++++++++++++++++++++++++++
 fs/btrfs/inode.c        |  4 ++--
 fs/btrfs/ioctl.c        |  4 ++--
 fs/btrfs/scrub.c        |  2 +-
 fs/btrfs/super.c        |  7 ++++---
 fs/btrfs/sysfs.c        |  2 +-
 fs/btrfs/transaction.c  |  8 ++++----
 fs/btrfs/transaction.h  |  2 +-
 fs/btrfs/tree-checker.c |  2 +-
 fs/btrfs/tree-log.c     |  6 +++---
 14 files changed, 112 insertions(+), 45 deletions(-)

Comments

David Sterba Oct. 6, 2023, 2:29 p.m. UTC | #1
On Wed, Oct 04, 2023 at 11:38:47AM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> The following remove some data races affecting mostly fsync. In general
> these are mostly harmless from a functional perspective, though there are
> a few cases that could cause some unexpected results but should be very
> rare to hit. There's also a couple cleanups here.
> More details on the changelogs.
> 
> Filipe Manana (6):
>   btrfs: add and use helpers for reading and writing last_log_commit
>   btrfs: add and use helpers for reading and writing log_transid
>   btrfs: add and use helpers for reading and writing fs_info->generation
>   btrfs: add and use helpers for reading and writing last_trans_committed
>   btrfs: remove pointless barrier from btrfs_sync_file()
>   btrfs: update comment for struct btrfs_inode::lock

Added to misc-next as the changes are straightforward, if there's any
fixup needed for the increments I'll do that in the commits after we
agree. Thanks.