[0/2] btrfs-progs: revert `btrfs subvolume delete --delete-qgroup` option

Message

Qu Wenruo April 25, 2024, 10:05 p.m. UTC

The introduction of `btrfs subvolume delete --delete-qgroup` would not
work for a lot of real world cases.

This would leads to unnecessary errors, and can be very confusing for
end users.

Furthermore the new options do not take the lifespan of a subvolume into
consideration or the possible conflicts with other qgroup features.

Although it's already too late, we should revert it to prevent further
confusion and damage.

Qu Wenruo (2):
  Revert "btrfs-progs: subvol delete: add options to delete the qgroup"
  btrfs: misc-tests: remove the subvol-delete-qgroup test case

 Documentation/btrfs-subvolume.rst             |  7 ---
 cmds/subvolume.c                              | 26 ----------
 .../061-subvol-delete-qgroup/test.sh          | 47 -------------------
 3 files changed, 80 deletions(-)
 delete mode 100755 tests/misc-tests/061-subvol-delete-qgroup/test.sh

--
2.44.0

Comments

David Sterba April 29, 2024, 5:29 p.m. UTC | #1

On Fri, Apr 26, 2024 at 07:35:51AM +0930, Qu Wenruo wrote:
> The introduction of `btrfs subvolume delete --delete-qgroup` would not
> work for a lot of real world cases.
> 
> This would leads to unnecessary errors, and can be very confusing for
> end users.
> 
> Furthermore the new options do not take the lifespan of a subvolume into
> consideration or the possible conflicts with other qgroup features.
> 
> Although it's already too late, we should revert it to prevent further
> confusion and damage.

The options have been there since 6.6.3 so it's about 2 full releases
but it better be removed now.

> Qu Wenruo (2):
>   Revert "btrfs-progs: subvol delete: add options to delete the qgroup"
>   btrfs: misc-tests: remove the subvol-delete-qgroup test case

Added to devel, thanks.