| Message ID | cover.1716234472.git.dsterba@suse.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Cleanups and W=2 warning fixes | expand |
On Mon, May 20, 2024 at 09:52:08PM +0200, David Sterba wrote: > We have a clean run of 'make W='1 with gcc 13, there are some > interesting warnings to fix with level 2 and even 3. We can't enable the > warning flags by defualt due to reports from generic code. > > This short series removes shadowed variables, adds const and removes > an unused macro. There are still some shadow variables to fix but the > remaining cases are with 'ret' variables so I skipped it for now. These LGTM. I did notice a few typos in the patch titles, though. Reviewed-by: Boris Burkov <boris@bur.io> > > David Sterba (6): > btrfs: remove duplicate name variable declarations > btrfs: rename macro local variables that clash with other variables > btrfs: use for-local variabls that shadow function variables btrfs: use for-local variables that shadow function variables > btrfs: remove unused define EXTENT_SIZE_PER_ITEM > btrfs: keep const whene returnin value from get_unaligned_le8() btrfs: keep const when returning value from get_unaligned_le8() > btrfs: constify parameters of write_eb_member() and its users > > fs/btrfs/accessors.h | 12 ++++++------ > fs/btrfs/extent_io.c | 6 ++---- > fs/btrfs/inode.c | 2 -- > fs/btrfs/qgroup.c | 11 +++++------ > fs/btrfs/space-info.c | 2 -- > fs/btrfs/subpage.c | 8 ++++---- > fs/btrfs/transaction.h | 6 +++--- > fs/btrfs/volumes.c | 9 +++------ > fs/btrfs/zoned.c | 8 +++----- > 9 files changed, 26 insertions(+), 38 deletions(-) > > -- > 2.45.0 >
On 5/21/24 03:52, David Sterba wrote: > We have a clean run of 'make W='1 with gcc 13, there are some > interesting warnings to fix with level 2 and even 3. We can't enable the > warning flags by defualt due to reports from generic code. > > This short series removes shadowed variables, adds const and removes > an unused macro. There are still some shadow variables to fix but the > remaining cases are with 'ret' variables so I skipped it for now. > > David Sterba (6): > btrfs: remove duplicate name variable declarations > btrfs: rename macro local variables that clash with other variables > btrfs: use for-local variabls that shadow function variables > btrfs: remove unused define EXTENT_SIZE_PER_ITEM > btrfs: keep const whene returnin value from get_unaligned_le8() > btrfs: constify parameters of write_eb_member() and its users Reviewed-by: Anand Jain <anand.jain@oracle.com> Thanks, Anand > > fs/btrfs/accessors.h | 12 ++++++------ > fs/btrfs/extent_io.c | 6 ++---- > fs/btrfs/inode.c | 2 -- > fs/btrfs/qgroup.c | 11 +++++------ > fs/btrfs/space-info.c | 2 -- > fs/btrfs/subpage.c | 8 ++++---- > fs/btrfs/transaction.h | 6 +++--- > fs/btrfs/volumes.c | 9 +++------ > fs/btrfs/zoned.c | 8 +++----- > 9 files changed, 26 insertions(+), 38 deletions(-) >
On Mon, May 20, 2024 at 09:52:08PM GMT, David Sterba wrote: > We have a clean run of 'make W='1 with gcc 13, there are some > interesting warnings to fix with level 2 and even 3. We can't enable the > warning flags by defualt due to reports from generic code. > > This short series removes shadowed variables, adds const and removes > an unused macro. There are still some shadow variables to fix but the > remaining cases are with 'ret' variables so I skipped it for now. > > David Sterba (6): > btrfs: remove duplicate name variable declarations > btrfs: rename macro local variables that clash with other variables > btrfs: use for-local variabls that shadow function variables > btrfs: remove unused define EXTENT_SIZE_PER_ITEM > btrfs: keep const whene returnin value from get_unaligned_le8() > btrfs: constify parameters of write_eb_member() and its users A small nit added to patch 3 but for whole the series Reviewed-by: Naohiro Aota <naohiro.aota@wdc.com> > fs/btrfs/accessors.h | 12 ++++++------ > fs/btrfs/extent_io.c | 6 ++---- > fs/btrfs/inode.c | 2 -- > fs/btrfs/qgroup.c | 11 +++++------ > fs/btrfs/space-info.c | 2 -- > fs/btrfs/subpage.c | 8 ++++---- > fs/btrfs/transaction.h | 6 +++--- > fs/btrfs/volumes.c | 9 +++------ > fs/btrfs/zoned.c | 8 +++----- > 9 files changed, 26 insertions(+), 38 deletions(-) > > -- > 2.45.0 >