| Message ID | cover.1718238120.git.wqu@suse.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | btrfs-progs: move RST feature back to experimental | expand |
> This patchset would hide RST feature back behind experimental builds for > mkfs, and completely disable rst for convert, so end users won't and > can't enable RST by accident. How about introduce a option named like "--experimental" to enable these feature? It can work perfectly and don't need me to re-compiling another btrfs-progs. HAN Yuwei
For the series,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Thanks
在 2024/6/13 17:17, HAN Yuwei 写道: >> This patchset would hide RST feature back behind experimental builds for >> mkfs, and completely disable rst for convert, so end users won't and >> can't enable RST by accident. > How about introduce a option named like "--experimental" to enable these > feature? Well, that's exactly what we (at least me) want, to make it harder for end uers to reach it. For you, with your advanced subpage and zoned setup, compiling btrfs-progs should only be a small hassle, and you only need to do it once. Thanks, Qu > > It can work perfectly and don't need me to re-compiling another > btrfs-progs. > > HAN Yuwei >
On 13.06.24 10:43, Qu Wenruo wrote: > > > 在 2024/6/13 17:17, HAN Yuwei 写道: >>> This patchset would hide RST feature back behind experimental builds for >>> mkfs, and completely disable rst for convert, so end users won't and >>> can't enable RST by accident. >> How about introduce a option named like "--experimental" to enable these >> feature? > > Well, that's exactly what we (at least me) want, to make it harder for > end uers to reach it. I completely agree with Qu here. As much as I love you being an early adopter for my RST stuff, it is not in a shape where I want it to be used by people. Also there will be a change in the on-disk format as well, so please do not (yet) use it. > For you, with your advanced subpage and zoned setup, compiling > btrfs-progs should only be a small hassle, and you only need to do it once. > > Thanks, > Qu >> >> It can work perfectly and don't need me to re-compiling another >> btrfs-progs. >> >> HAN Yuwei >> > >
Although we have exported raid-stripe-tree feature to end users, the feature is still experimental as only kernels with CONFIG_BTRFS_DEBUG can even mount it. This results a feature mismatch in btrfs-progs and kernels, and can lead to complains/confusion from end users. This patchset would hide RST feature back behind experimental builds for mkfs, and completely disable rst for convert, so end users won't and can't enable RST by accident. Now RST related test cases (mkfs/029, mkfs/030) are skipped for regular builds, and a new test case (mkfs/033) is skipped for experimental builds to make sure there is really no way to enable RST support for non-experimental builds. The new experimental build detection also provides the basis for other experimental features like csum conversion in the future (recent days). Both regular and experimental builds have passed the full test suite (except random misc/055 failure, which is caused by a clear-stale behavior change, and will be addressed separately) Qu Wenruo (4): btrfs-progs: convert: remove raid-stripe-tree support btrfs-progs: hide rst related mkfs tests behind experimental builds btrfs-progs: fsfeatures: move RST back to experimental btrfs-progs: mkfs-tests: ensure regular builds won't enable rst feature common/fsfeatures.c | 2 ++ common/fsfeatures.h | 3 +- mkfs/main.c | 2 ++ tests/common | 29 ++++++++++++++++ tests/convert-tests/001-ext2-basic/test.sh | 2 +- tests/convert-tests/003-ext4-basic/test.sh | 2 +- .../005-delete-all-rollback/test.sh | 2 +- .../convert-tests/010-reiserfs-basic/test.sh | 2 +- .../011-reiserfs-delete-all-rollback/test.sh | 2 +- tests/convert-tests/024-ntfs-basic/test.sh | 2 +- tests/mkfs-tests/029-raid-stripe-tree/test.sh | 1 + tests/mkfs-tests/030-zoned-rst/test.sh | 1 + tests/mkfs-tests/033-zoned-reject-rst/test.sh | 34 +++++++++++++++++++ 13 files changed, 76 insertions(+), 8 deletions(-) create mode 100755 tests/mkfs-tests/033-zoned-reject-rst/test.sh -- 2.45.2