| Message ID | cover.1724795623.git.dsterba@suse.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Renames and defrag cleanups | expand |
在 2024/8/28 07:25, David Sterba 写道: > A few simple cleanups, dropping underscores and improving some code in > defrag. > > David Sterba (12): > btrfs: rename btrfs_submit_bio() to btrfs_submit_bbio() > btrfs: rename __btrfs_submit_bio() and drop double underscores > btrfs: rename __extent_writepage() and drop double underscores > btrfs: rename __compare_inode_defrag() and drop double underscores > btrfs: constify arguments of compare_inode_defrag() > btrfs: rename __need_auto_defrag() and drop double underscores > btrfs: rename __btrfs_add_inode_defrag() and drop double underscores > btrfs: rename __btrfs_run_defrag_inode() and drop double underscores > btrfs: clear defragmented inodes using postorder in > btrfs_cleanup_defrag_inodes() This one doesn't look safe to me as the rbtree_postorder_for_each_safe() doesn't look like interruption safe. The remaining ones looks good to me. Reviewed-by: Qu Wenruo <wqu@suse.com> Thanks, Qu > btrfs: return void from btrfs_add_inode_defrag() > btrfs: drop transaction parameter from btrfs_add_inode_defrag() > btrfs: always pass readahead state to defrag > > fs/btrfs/bio.c | 20 +++---- > fs/btrfs/bio.h | 6 +-- > fs/btrfs/compression.c | 4 +- > fs/btrfs/defrag.c | 100 ++++++++++++++--------------------- > fs/btrfs/defrag.h | 3 +- > fs/btrfs/direct-io.c | 2 +- > fs/btrfs/extent_io.c | 34 ++++++------ > fs/btrfs/inode.c | 8 +-- > fs/btrfs/scrub.c | 10 ++-- > fs/btrfs/subpage.c | 4 +- > include/trace/events/btrfs.h | 2 +- > 11 files changed, 86 insertions(+), 107 deletions(-) >
A few simple cleanups, dropping underscores and improving some code in defrag. David Sterba (12): btrfs: rename btrfs_submit_bio() to btrfs_submit_bbio() btrfs: rename __btrfs_submit_bio() and drop double underscores btrfs: rename __extent_writepage() and drop double underscores btrfs: rename __compare_inode_defrag() and drop double underscores btrfs: constify arguments of compare_inode_defrag() btrfs: rename __need_auto_defrag() and drop double underscores btrfs: rename __btrfs_add_inode_defrag() and drop double underscores btrfs: rename __btrfs_run_defrag_inode() and drop double underscores btrfs: clear defragmented inodes using postorder in btrfs_cleanup_defrag_inodes() btrfs: return void from btrfs_add_inode_defrag() btrfs: drop transaction parameter from btrfs_add_inode_defrag() btrfs: always pass readahead state to defrag fs/btrfs/bio.c | 20 +++---- fs/btrfs/bio.h | 6 +-- fs/btrfs/compression.c | 4 +- fs/btrfs/defrag.c | 100 ++++++++++++++--------------------- fs/btrfs/defrag.h | 3 +- fs/btrfs/direct-io.c | 2 +- fs/btrfs/extent_io.c | 34 ++++++------ fs/btrfs/inode.c | 8 +-- fs/btrfs/scrub.c | 10 ++-- fs/btrfs/subpage.c | 4 +- include/trace/events/btrfs.h | 2 +- 11 files changed, 86 insertions(+), 107 deletions(-)