[0/8] btrfs: delayed refs and qgroups, fixes, cleanups, improvements

Message

Filipe Manana Sept. 25, 2024, 10:50 a.m. UTC

From: Filipe Manana <[e-mail]>

Some fixes around delayed refs and qgroups after the conversion of a
red black tree to xarray in this merge window, and some improvements
and cleanups. Details in the changelogs.

Filipe Manana (8):
  btrfs: fix missing error handling when adding delayed ref with qgroups enabled
  btrfs: use sector numbers as keys for the dirty extents xarray
  btrfs: end assignment with semicolon at btrfs_qgroup_extent event class
  btrfs: qgroups: remove bytenr field from struct btrfs_qgroup_extent_record
  btrfs: store fs_info in a local variable at btrfs_qgroup_trace_extent_post()
  btrfs: remove unnecessary delayed refs locking at btrfs_qgroup_trace_extent()
  btrfs: always use delayed_refs local variable at btrfs_qgroup_trace_extent()
  btrfs: remove pointless initialization at btrfs_qgroup_trace_extent()

 fs/btrfs/delayed-ref.c       | 59 ++++++++++++++++++++++++++----------
 fs/btrfs/delayed-ref.h       | 10 +++++-
 fs/btrfs/qgroup.c            | 58 +++++++++++++++++------------------
 fs/btrfs/qgroup.h            | 13 ++++++--
 include/trace/events/btrfs.h | 17 ++++++-----
 5 files changed, 101 insertions(+), 56 deletions(-)

Comments

Qu Wenruo Sept. 25, 2024, 10:35 p.m. UTC | #1

在 2024/9/25 20:20, [e-mail] 写道:
> From: Filipe Manana <[e-mail]>
>
> Some fixes around delayed refs and qgroups after the conversion of a
> red black tree to xarray in this merge window, and some improvements
> and cleanups. Details in the changelogs.
>
> Filipe Manana (8):
>    btrfs: fix missing error handling when adding delayed ref with qgroups enabled
>    btrfs: use sector numbers as keys for the dirty extents xarray

I'd prefer an error out other than continuing if the record->bytenr goes
beyond MAX_LFS_FILESIZE to be extra safe on 32bit systems.

Otherwise the remaining patches look good to me.

Thanks for the cleanup, especially since the convert to xarray
introduces extra xa_lock for us, it means we do not need to re-use the
delayed refs lock.

Thanks,
Qu

>    btrfs: end assignment with semicolon at btrfs_qgroup_extent event class
>    btrfs: qgroups: remove bytenr field from struct btrfs_qgroup_extent_record
>    btrfs: store fs_info in a local variable at btrfs_qgroup_trace_extent_post()
>    btrfs: remove unnecessary delayed refs locking at btrfs_qgroup_trace_extent()
>    btrfs: always use delayed_refs local variable at btrfs_qgroup_trace_extent()
>    btrfs: remove pointless initialization at btrfs_qgroup_trace_extent()
>
>   fs/btrfs/delayed-ref.c       | 59 ++++++++++++++++++++++++++----------
>   fs/btrfs/delayed-ref.h       | 10 +++++-
>   fs/btrfs/qgroup.c            | 58 +++++++++++++++++------------------
>   fs/btrfs/qgroup.h            | 13 ++++++--
>   include/trace/events/btrfs.h | 17 ++++++-----
>   5 files changed, 101 insertions(+), 56 deletions(-)
>