mbox series

[00/18] Random cleanups for 6.14

Message ID cover.1736418116.git.dsterba@suse.com (mailing list archive)
Headers show
Series Random cleanups for 6.14 | expand

Message

David Sterba Jan. 9, 2025, 10:23 a.m. UTC 
Unsorteed small cleanups and renames.

David Sterba (18):
  btrfs: drop unused parameter fs_info to btrfs_delete_delayed_insertion_item()
  btrfs: remove stray comment about SRCU
  btrfs: use SECTOR_SIZE defines in btrfs_issue_discard()
  btrfs: rename __unlock_for_delalloc() and drop underscores
  btrfs: open code set_page_extent_mapped()
  btrfs: rename __get_extent_map() and pass btrfs_inode
  btrfs: use btrfs_inode in extent_writepage()
  btrfs: make wait_on_extent_buffer_writeback() static inline
  btrfs: drop one time used local variable in end_bbio_meta_write()
  btrfs: open code __free_extent_buffer()
  btrfs: rename btrfs_release_extent_buffer_pages() to mention folios
  btrfs: switch grab_extent_buffer() to folios
  btrfs: change return type to bool type of check_eb_alignment()
  btrfs: unwrap folio locking helpers
  btrfs: remove unused define WAIT_PAGE_LOCK for extent io
  btrfs: split waiting from read_extent_buffer_pages(), drop parameter wait
  btrfs: remove redundant variables from __process_folios_contig() and lock_delalloc_folios()
  btrfs: async-thread: rename DFT_THRESHOLD to DEFAULT_THRESHOLD

 fs/btrfs/async-thread.c     |   6 +-
 fs/btrfs/delayed-inode.c    |   5 +-
 fs/btrfs/disk-io.c          |   2 +-
 fs/btrfs/disk-io.h          |   3 -
 fs/btrfs/extent-tree.c      |   4 +-
 fs/btrfs/extent_io.c        | 143 ++++++++++++++++--------------------
 fs/btrfs/extent_io.h        |  16 ++--
 fs/btrfs/free-space-cache.c |   2 +-
 fs/btrfs/relocation.c       |   2 +-
 9 files changed, 84 insertions(+), 99 deletions(-)

Comments

Johannes Thumshirn Jan. 9, 2025, 1:41 p.m. UTC | #1 
On 09.01.25 11:26, David Sterba wrote:
> Unsorteed small cleanups and renames.
> 
> David Sterba (18):
>    btrfs: drop unused parameter fs_info to btrfs_delete_delayed_insertion_item()
>    btrfs: remove stray comment about SRCU
>    btrfs: use SECTOR_SIZE defines in btrfs_issue_discard()
>    btrfs: rename __unlock_for_delalloc() and drop underscores
>    btrfs: open code set_page_extent_mapped()
>    btrfs: rename __get_extent_map() and pass btrfs_inode
>    btrfs: use btrfs_inode in extent_writepage()
>    btrfs: make wait_on_extent_buffer_writeback() static inline
>    btrfs: drop one time used local variable in end_bbio_meta_write()
>    btrfs: open code __free_extent_buffer()
>    btrfs: rename btrfs_release_extent_buffer_pages() to mention folios
>    btrfs: switch grab_extent_buffer() to folios
>    btrfs: change return type to bool type of check_eb_alignment()
>    btrfs: unwrap folio locking helpers
>    btrfs: remove unused define WAIT_PAGE_LOCK for extent io
>    btrfs: split waiting from read_extent_buffer_pages(), drop parameter wait
>    btrfs: remove redundant variables from __process_folios_contig() and lock_delalloc_folios()
>    btrfs: async-thread: rename DFT_THRESHOLD to DEFAULT_THRESHOLD
> 
>   fs/btrfs/async-thread.c     |   6 +-
>   fs/btrfs/delayed-inode.c    |   5 +-
>   fs/btrfs/disk-io.c          |   2 +-
>   fs/btrfs/disk-io.h          |   3 -
>   fs/btrfs/extent-tree.c      |   4 +-
>   fs/btrfs/extent_io.c        | 143 ++++++++++++++++--------------------
>   fs/btrfs/extent_io.h        |  16 ++--
>   fs/btrfs/free-space-cache.c |   2 +-
>   fs/btrfs/relocation.c       |   2 +-
>   9 files changed, 84 insertions(+), 99 deletions(-)
> 

Apart from the small nitpicks

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

for the series.
Anand Jain Jan. 9, 2025, 4:45 p.m. UTC | #2 
On 9/1/25 15:53, David Sterba wrote:
> Unsorteed small cleanups and renames.
> 
> David Sterba (18):
>    btrfs: drop unused parameter fs_info to btrfs_delete_delayed_insertion_item()
>    btrfs: remove stray comment about SRCU
>    btrfs: use SECTOR_SIZE defines in btrfs_issue_discard()
>    btrfs: rename __unlock_for_delalloc() and drop underscores
>    btrfs: open code set_page_extent_mapped()
>    btrfs: rename __get_extent_map() and pass btrfs_inode
>    btrfs: use btrfs_inode in extent_writepage()
>    btrfs: make wait_on_extent_buffer_writeback() static inline
>    btrfs: drop one time used local variable in end_bbio_meta_write()
>    btrfs: open code __free_extent_buffer()
>    btrfs: rename btrfs_release_extent_buffer_pages() to mention folios
>    btrfs: switch grab_extent_buffer() to folios
>    btrfs: change return type to bool type of check_eb_alignment()
>    btrfs: unwrap folio locking helpers
>    btrfs: remove unused define WAIT_PAGE_LOCK for extent io
>    btrfs: split waiting from read_extent_buffer_pages(), drop parameter wait
>    btrfs: remove redundant variables from __process_folios_contig() and lock_delalloc_folios()
>    btrfs: async-thread: rename DFT_THRESHOLD to DEFAULT_THRESHOLD
> 

For the set.
Reviewed-by: Anand Jain <anand.jain@oracle.com>

Thx.

>   fs/btrfs/async-thread.c     |   6 +-
>   fs/btrfs/delayed-inode.c    |   5 +-
>   fs/btrfs/disk-io.c          |   2 +-
>   fs/btrfs/disk-io.h          |   3 -
>   fs/btrfs/extent-tree.c      |   4 +-
>   fs/btrfs/extent_io.c        | 143 ++++++++++++++++--------------------
>   fs/btrfs/extent_io.h        |  16 ++--
>   fs/btrfs/free-space-cache.c |   2 +-
>   fs/btrfs/relocation.c       |   2 +-
>   9 files changed, 84 insertions(+), 99 deletions(-)
>