mbox series

[v2,0/5] fstests: btrfs: add test case to validate sysfs input arguments

Message ID cover.1738752716.git.anand.jain@oracle.com (mailing list archive)
Headers show
Series fstests: btrfs: add test case to validate sysfs input arguments | expand

Message

Anand Jain Feb. 5, 2025, 11:06 a.m. UTC 
v2:
Mainly adds a generic function to check if a sysfs attribute reports
invalid input.

v1:
https://lwn.net/ml/all/cover.1738161075.git.anand.jain@oracle.com/

Anand Jain (5):
  fstests: common/rc: set_fs_sysfs_attr: redirect errors to stdout
  fstests: filter: helper for sysfs error filtering
  fstests: common/rc: add sysfs argument verification helpers
  fstests: btrfs: testcase for sysfs policy syntax verification
  fstests: btrfs: testcase for sysfs chunk_size attribute validation

 common/filter       |   9 +++
 common/rc           | 139 +++++++++++++++++++++++++++++++++++++++++++-
 tests/btrfs/329     |  18 ++++++
 tests/btrfs/329.out |  19 ++++++
 tests/btrfs/334     |  18 ++++++
 tests/btrfs/334.out |  14 +++++
 6 files changed, 216 insertions(+), 1 deletion(-)
 create mode 100755 tests/btrfs/329
 create mode 100644 tests/btrfs/329.out
 create mode 100755 tests/btrfs/334
 create mode 100644 tests/btrfs/334.out

Comments

Dave Chinner Feb. 5, 2025, 9:21 p.m. UTC | #1 
On Wed, Feb 05, 2025 at 07:06:35PM +0800, Anand Jain wrote:
> v2:
> Mainly adds a generic function to check if a sysfs attribute reports
> invalid input.
> 
> v1:
> https://lwn.net/ml/all/cover.1738161075.git.anand.jain@oracle.com/
> 
> Anand Jain (5):
>   fstests: common/rc: set_fs_sysfs_attr: redirect errors to stdout
>   fstests: filter: helper for sysfs error filtering
>   fstests: common/rc: add sysfs argument verification helpers
>   fstests: btrfs: testcase for sysfs policy syntax verification
>   fstests: btrfs: testcase for sysfs chunk_size attribute validation

All looks ok, except for my comment about creating common/sysfs for
all the sysfs stuff. The individual tests look much simpler and
nicer, too.

-Dave.
Anand Jain Feb. 5, 2025, 11:30 p.m. UTC | #2 
On 6/2/25 05:21, Dave Chinner wrote:
> On Wed, Feb 05, 2025 at 07:06:35PM +0800, Anand Jain wrote:
>> v2:
>> Mainly adds a generic function to check if a sysfs attribute reports
>> invalid input.
>>
>> v1:
>> https://lwn.net/ml/all/cover.1738161075.git.anand.jain@oracle.com/
>>
>> Anand Jain (5):
>>    fstests: common/rc: set_fs_sysfs_attr: redirect errors to stdout
>>    fstests: filter: helper for sysfs error filtering
>>    fstests: common/rc: add sysfs argument verification helpers
>>    fstests: btrfs: testcase for sysfs policy syntax verification
>>    fstests: btrfs: testcase for sysfs chunk_size attribute validation
> 
> All looks ok, except for my comment about creating common/sysfs for
> all the sysfs stuff. The individual tests look much simpler and
> nicer, too.
> 

Yeah, the sysfs functions need a new file. I'll send the reorg cleanups.

Thx, Anand

> -Dave.