Revert "btrfs: zoned: fail mount if the device does not support zone append"

Commit Message

Johannes Thumshirn July 1, 2021, 8:13 a.m. UTC

Now that the device-mapper code can fully emulate zone append there's  no
need for this check anymore.

This reverts commit 1d68128c107a0b8c0c9125cb05d4771ddc438369.

Cc: Naohiro  Aota <[e-mail]>
Cc: Damien Le Moal <[e-mail]>
Singed-off-by: Johannes Thumshirn <[e-mail]>
---
 fs/btrfs/zoned.c | 7 -------
 1 file changed, 7 deletions(-)

Comments

David Sterba July 1, 2021, 9:34 a.m. UTC | #1

On Thu, Jul 01, 2021 at 05:13:37PM +0900, Johannes Thumshirn wrote:
> Now that the device-mapper code can fully emulate zone append there's  no
> need for this check anymore.

Which commit implements that? I did a quick search for 'append' in the
recent git history there and found nothing.
> 
> This reverts commit 1d68128c107a0b8c0c9125cb05d4771ddc438369.

Please do commit references as 1d68128c107a ("btrfs: zoned: fail mount if the
device does not support zone append") .

Johannes Thumshirn July 1, 2021, 9:49 a.m. UTC | #2

On 01/07/2021 11:37, David Sterba wrote:
> On Thu, Jul 01, 2021 at 05:13:37PM +0900, Johannes Thumshirn wrote:
>> Now that the device-mapper code can fully emulate zone append there's  no
>> need for this check anymore.
> 
> Which commit implements that? I did a quick search for 'append' in the
> recent git history there and found nothing.

The series is on it's way to Linus:
https://lore.kernel.org/linux-block/[e-mail]

I'll resend the patch once it hits Linus' tree and has a stable commit id.

>>
>> This reverts commit 1d68128c107a0b8c0c9125cb05d4771ddc438369.
> 
> Please do commit references as 1d68128c107a ("btrfs: zoned: fail mount if the
> device does not support zone append") .
> 


Will do.

Patch

diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index 297c0b1c0634..e4087a2364a2 100644
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -354,13 +354,6 @@  int btrfs_get_dev_zone_info(struct btrfs_device *device)
 	if (!IS_ALIGNED(nr_sectors, zone_sectors))
 		zone_info->nr_zones++;
 
-	if (bdev_is_zoned(bdev) && zone_info->max_zone_append_size == 0) {
-		btrfs_err(fs_info, "zoned: device %pg does not support zone append",
-			  bdev);
-		ret = -EINVAL;
-		goto out;
-	}
-
 	zone_info->seq_zones = bitmap_zalloc(zone_info->nr_zones, GFP_KERNEL);
 	if (!zone_info->seq_zones) {
 		ret = -ENOMEM;