diff mbox series

[3/8] common/btrfs: add a _require_btrfs_no_nodatasum helper

Message ID 09d16bf76cfe7317f584c2bbaeacb2ee810dcd99.1739379184.git.fdmanana@suse.com (mailing list archive)
State New
Headers show
Series fstests: btrfs: fix test failure when running with compression or nodatasum | expand

Commit Message

Filipe Manana Feb. 12, 2025, 5:01 p.m. UTC 
From: Filipe Manana <fdmanana@suse.com>

Add a _require_btrfs_no_nodatasum helper to skip a test if the nodatasum
mount option is give, as we do have several tests that fail, for several
reasons, when that mount option is passed.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
 common/btrfs | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Johannes Thumshirn Feb. 12, 2025, 5:20 p.m. UTC | #1 
All those double negations XD

Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
diff mbox series

Patch

diff --git a/common/btrfs b/common/btrfs
index 5d69ddd8..a3b9c12f 100644
--- a/common/btrfs
+++ b/common/btrfs
@@ -134,6 +134,13 @@  _require_btrfs_no_nodatacow()
 	fi
 }
 
+_require_btrfs_no_nodatasum()
+{
+	if _normalize_mount_options "$MOUNT_OPTIONS" | grep -q "nodatasum"; then
+		_notrun "This test requires no nodatasum enabled"
+	fi
+}
+
 _require_btrfs_free_space_tree()
 {
 	_scratch_mkfs > /dev/null 2>&1