diff mbox series

generic/019: redirect fsstress output to log file instead

Message ID 0fdc35fdbc53f739fce1cb46ede8af97829aea11.1722441479.git.fdmanana@suse.com (mailing list archive)
State New, archived
Headers show
Series generic/019: redirect fsstress output to log file instead | expand

Commit Message

Filipe Manana July 31, 2024, 3:59 p.m. UTC
From: Filipe Manana <fdmanana@suse.com>

Currently we are redirecting stdout and stderr of fsstress to /dev/null.
In case we have a test failure, it's useful to know the seed that
fsstress was using because it might be helpful to run it again with that
same seed in the hope of being able to reproduce the failure.

So redirect stdout/stderr to the log file $seqres.full instead, so
that we'll see a line like this after running the test:

    seed = 1722389488

Signed-off-by: Filipe Manana <fdmanana@suse.com>
---
 tests/generic/019 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Sterba July 31, 2024, 4:20 p.m. UTC | #1
On Wed, Jul 31, 2024 at 04:59:24PM +0100, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Currently we are redirecting stdout and stderr of fsstress to /dev/null.
> In case we have a test failure, it's useful to know the seed that
> fsstress was using because it might be helpful to run it again with that
> same seed in the hope of being able to reproduce the failure.
> 
> So redirect stdout/stderr to the log file $seqres.full instead, so
> that we'll see a line like this after running the test:
> 
>     seed = 1722389488
> 
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: David Sterba <dsterba@suse.com>
Qu Wenruo July 31, 2024, 11:29 p.m. UTC | #2
在 2024/8/1 01:29, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
>
> Currently we are redirecting stdout and stderr of fsstress to /dev/null.
> In case we have a test failure, it's useful to know the seed that
> fsstress was using because it might be helpful to run it again with that
> same seed in the hope of being able to reproduce the failure.
>
> So redirect stdout/stderr to the log file $seqres.full instead, so
> that we'll see a line like this after running the test:
>
>      seed = 1722389488
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>   tests/generic/019 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/019 b/tests/generic/019
> index 26108be4..fe117ac8 100755
> --- a/tests/generic/019
> +++ b/tests/generic/019
> @@ -90,7 +90,7 @@ _workout()
>   	echo "Start fsstress.."
>   	echo ""
>   	echo "fsstress $args" >> $seqres.full
> -	$FSSTRESS_PROG $args > /dev/null 2>&1 &
> +	$FSSTRESS_PROG $args >> $seqres.full 2>&1 &
>   	fs_pid=$!
>   	echo "Start fio.."
>   	cat $fio_config >>  $seqres.full
diff mbox series

Patch

diff --git a/tests/generic/019 b/tests/generic/019
index 26108be4..fe117ac8 100755
--- a/tests/generic/019
+++ b/tests/generic/019
@@ -90,7 +90,7 @@  _workout()
 	echo "Start fsstress.."
 	echo ""
 	echo "fsstress $args" >> $seqres.full
-	$FSSTRESS_PROG $args > /dev/null 2>&1 &
+	$FSSTRESS_PROG $args >> $seqres.full 2>&1 &
 	fs_pid=$!
 	echo "Start fio.."
 	cat $fio_config >>  $seqres.full