From patchwork Mon May 30 19:11:21 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Mason X-Patchwork-Id: 830812 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p4UJBi4g005252 for ; Mon, 30 May 2011 19:11:44 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756926Ab1E3TLi (ORCPT ); Mon, 30 May 2011 15:11:38 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:29927 "EHLO rcsinet10.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754943Ab1E3TLg (ORCPT ); Mon, 30 May 2011 15:11:36 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p4UJBUoX019192 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 30 May 2011 19:11:31 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p4UJBTmD019322 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 30 May 2011 19:11:30 GMT Received: from abhmt014.oracle.com (abhmt014.oracle.com [141.146.116.23]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p4UJBOE1016921; Mon, 30 May 2011 14:11:24 -0500 Received: from localhost (/221.245.165.18) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 30 May 2011 12:11:24 -0700 From: Chris Mason To: Daniel J Blueman Cc: Miao Xie , Linux BTRFS Subject: Re: [3.0-rc1] delayed insertion allocation failing... In-reply-to: References: Date: Mon, 30 May 2011 15:11:21 -0400 Message-Id: <1306782464-sup-7709@shiny> User-Agent: Sup/git X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.4DE3EBE4.002F:SCFMA922111,ss=1,fgs=0 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Mon, 30 May 2011 19:11:44 +0000 (UTC) Excerpts from Daniel J Blueman's message of 2011-05-30 10:24:08 -0400: > Hi Miao, > > When booting 3.0-rc1 with an existing BTRFS filesystem with a normal > desktop use pattern, we see btrfs_batch_insert_item() sometimes > attempt an overly-large kmalloc (>= order 11) [1], which is > subsequently failed. Wow, that's a big allocation. Not really sure how this manages to compile with a warning. --- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c index 01e2950..790262d 100644 --- a/fs/btrfs/delayed-inode.c +++ b/fs/btrfs/delayed-inode.c @@ -678,6 +678,7 @@ static int btrfs_batch_insert_items(struct btrfs_trans_handle *trans, INIT_LIST_HEAD(&head); next = item; + nitems = 0; /* * count the number of the continuous items that we can insert in batch