From patchwork Sun Jun 30 11:51:44 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Filipe Manana X-Patchwork-Id: 2804441 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 16167BF4A1 for ; Sun, 30 Jun 2013 11:53:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3E48020109 for ; Sun, 30 Jun 2013 11:53:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6DA8D20108 for ; Sun, 30 Jun 2013 11:53:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751202Ab3F3LxB (ORCPT ); Sun, 30 Jun 2013 07:53:01 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:57948 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813Ab3F3LxA (ORCPT ); Sun, 30 Jun 2013 07:53:00 -0400 Received: by mail-wi0-f179.google.com with SMTP id hj3so2234821wib.0 for ; Sun, 30 Jun 2013 04:52:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=5k1iZpcaU82H7DceNuu6Bq7nQrDB3YAn/0k6zOk+okY=; b=P3CzKCaXEJmcF8ICU0iEp2JG0Ca6deeP1ZrBxO+CoiGDWvyWzz4VxH/pRLXl1+MTrz CwU+YB8nrQifbaWk+staflcj+foZFqPUR5rxMOw6N7DoiFGcqsNmR9Ugptg9N4yEjJhD YWwDdl53wNJFAsJnWqxc2T+9hfORoSJcxqZaEyHFCUCF6Vbdbc2qMA2WGmmqnxh6ek+4 wBE6o/Wb7mid8t5dyE+ZYKKb3oOHfPT+2CmZgEEtQ4yh0qLy/GKiZW2MJbf0lfvxbqnc 8bBd/VbrCKecAzchGXXNfjSdqWlAZ30JzSf75W9GMrxae7Xi6EsVcfGoMzgbaSQiwXNJ P5MA== X-Received: by 10.180.211.7 with SMTP id my7mr9415381wic.26.1372593179238; Sun, 30 Jun 2013 04:52:59 -0700 (PDT) Received: from storm-desktop.lan (bl11-92-143.dsl.telepac.pt. [85.244.92.143]) by mx.google.com with ESMTPSA id z6sm9396421wiv.11.2013.06.30.04.52.58 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 30 Jun 2013 04:52:58 -0700 (PDT) From: Filipe David Borba Manana To: linux-btrfs@vger.kernel.org Cc: Filipe David Borba Manana Subject: [PATCH 1/3] Btrfs-progs: add missing write check for mkfs Date: Sun, 30 Jun 2013 12:51:44 +0100 Message-Id: <1372593106-6593-2-git-send-email-fdmanana@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1372593106-6593-1-git-send-email-fdmanana@gmail.com> References: <1372593106-6593-1-git-send-email-fdmanana@gmail.com> Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Assert that the write of the device tree root succeeds. This verification is currently done for all other tree roots, however it was missing for the device tree root. Would this tree root write fail, but all others succeed, it would lead to a corrupted/incomplete btrfs filesystem. Signed-off-by: Filipe David Borba Manana --- utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/utils.c b/utils.c index 7b4cd74..43d93f1 100644 --- a/utils.c +++ b/utils.c @@ -381,6 +381,7 @@ int make_btrfs(int fd, const char *device, const char *label, btrfs_set_header_nritems(buf, nritems); csum_tree_block_size(buf, BTRFS_CRC32_SIZE, 0); ret = pwrite(fd, buf->data, leafsize, blocks[4]); + BUG_ON(ret != leafsize); /* create the FS root */ memset(buf->data+sizeof(struct btrfs_header), 0,