| Message ID | 1373031307-22590-1-git-send-email-fdmanana@gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Fri, Jul 05, 2013 at 02:35:07PM +0100, Filipe David Borba Manana wrote: > In btrfs_set_block_flags() we want to check if the slot > in the leaf points to the first item in the leaf - if it > doesn't check if the previous item in the leaf is an extent > item. By removing this extra slot decrement we are indeed > checking the item right before the slot, and not the second > item before. > > Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com> > --- > extent-tree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/extent-tree.c b/extent-tree.c > index 381572d..5b6c7aa 100644 > --- a/extent-tree.c > +++ b/extent-tree.c > @@ -1609,7 +1609,7 @@ again: > > if (ret > 0 && skinny_metadata) { > skinny_metadata = 0; > - if (path->slots[0]--) { > + if (path->slots[0]) { > path->slots[0]--; > btrfs_item_key_to_cpu(path->nodes[0], &key, > path->slots[0]); Reviewed-by: Josef Bacik <jbacik@fusionio.com> Thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/extent-tree.c b/extent-tree.c index 381572d..5b6c7aa 100644 --- a/extent-tree.c +++ b/extent-tree.c @@ -1609,7 +1609,7 @@ again: if (ret > 0 && skinny_metadata) { skinny_metadata = 0; - if (path->slots[0]--) { + if (path->slots[0]) { path->slots[0]--; btrfs_item_key_to_cpu(path->nodes[0], &key, path->slots[0]);
In btrfs_set_block_flags() we want to check if the slot in the leaf points to the first item in the leaf - if it doesn't check if the previous item in the leaf is an extent item. By removing this extra slot decrement we are indeed checking the item right before the slot, and not the second item before. Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com> --- extent-tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)