diff mbox

[v2] Btrfs-progs: remove incorrect slot decrement

Message ID 1373057014-1424-1-git-send-email-fdmanana@gmail.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Filipe Manana July 5, 2013, 8:43 p.m. UTC 
In btrfs_set_block_flags() we want to check if the slot
in the leaf points to the first item in the leaf - if it
doesn't check if the previous item in the leaf is an extent
item. By removing this extra slot decrement we are indeed
checking the item right before the slot, and not the second
item before.

V2: Added Josef Bacik's review mention.

Reviewed-by: Josef Bacik <jbacik@fusionio.com>
Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com>
---
 extent-tree.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Sterba July 8, 2013, 4:14 p.m. UTC | #1 
On Fri, Jul 05, 2013 at 09:43:34PM +0100, Filipe David Borba Manana wrote:
> In btrfs_set_block_flags() we want to check if the slot
> in the leaf points to the first item in the leaf - if it
> doesn't check if the previous item in the leaf is an extent
> item. By removing this extra slot decrement we are indeed
> checking the item right before the slot, and not the second
> item before.
> 
> V2: Added Josef Bacik's review mention.

Please don't do that. It's ok to increase version if you update code or
changelog/subject, but not just the tags.

thanks,
david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Filipe Manana July 8, 2013, 4:16 p.m. UTC | #2 
Ok, sorry.
I'm not used to git send-email and related best practices.

Thanks for letting me know.

On Mon, Jul 8, 2013 at 5:14 PM, David Sterba <dsterba@suse.cz> wrote:
> On Fri, Jul 05, 2013 at 09:43:34PM +0100, Filipe David Borba Manana wrote:
>> In btrfs_set_block_flags() we want to check if the slot
>> in the leaf points to the first item in the leaf - if it
>> doesn't check if the previous item in the leaf is an extent
>> item. By removing this extra slot decrement we are indeed
>> checking the item right before the slot, and not the second
>> item before.
>>
>> V2: Added Josef Bacik's review mention.
>
> Please don't do that. It's ok to increase version if you update code or
> changelog/subject, but not just the tags.
>
> thanks,
> david
diff mbox

Patch

diff --git a/extent-tree.c b/extent-tree.c
index f597e16..e04160b 100644
--- a/extent-tree.c
+++ b/extent-tree.c
@@ -1596,7 +1596,7 @@  again:
 
 	if (ret > 0 && skinny_metadata) {
 		skinny_metadata = 0;
-		if (path->slots[0]--) {
+		if (path->slots[0]) {
 			path->slots[0]--;
 			btrfs_item_key_to_cpu(path->nodes[0], &key,
 					      path->slots[0]);