From patchwork Wed Sep 4 15:22:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wang Shilong X-Patchwork-Id: 2853759 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 47FF0C0AB5 for ; Wed, 4 Sep 2013 15:23:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1DDD4201ED for ; Wed, 4 Sep 2013 15:23:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E5AF204CB for ; Wed, 4 Sep 2013 15:23:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934847Ab3IDPXg (ORCPT ); Wed, 4 Sep 2013 11:23:36 -0400 Received: from mail-pb0-f42.google.com ([209.85.160.42]:57111 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934783Ab3IDPXe (ORCPT ); Wed, 4 Sep 2013 11:23:34 -0400 Received: by mail-pb0-f42.google.com with SMTP id un15so454131pbc.1 for ; Wed, 04 Sep 2013 08:23:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jaPKUj8Jqgi7OwMbxXOS8sJJ0M7z8aA0rccz3CHoEc4=; b=Zbn8R1wbcPVGVGi9i27sQsr8f/ySEwtdZJOFTozFUD6IsREVUBOWxNuugc83Tfwmp9 ePxhyYdowF3xPjQ/f9mDK6t8bg6tPz0pWP0k7/2LOem1E/3q7V9ZQHm6KxMF69KuyPvb /Z5mDbuiWvwLmmwVkrvL7NXzS6c7JZ6oFAzDBdh1F+xGjdZmjxVrsm7301FLOHBzVUsv HR7LZpLLhhVCj+6HQMM4nTaDpGch1ULp7FvC3fmou10aF5B6C+7qK/wrG+iXKIorT0y6 IxDwq8xbrpvPRog8m2dbRw/moji1lVTmofY0BhEKTH76Q8tjhdF7JRaA3dp/dBEC9BYa LEVQ== X-Received: by 10.67.22.67 with SMTP id hq3mr3857009pad.132.1378308214047; Wed, 04 Sep 2013 08:23:34 -0700 (PDT) Received: from localhost.localdomain.localdomain ([223.65.191.73]) by mx.google.com with ESMTPSA id uw6sm29467271pbc.8.1969.12.31.16.00.00 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 04 Sep 2013 08:23:33 -0700 (PDT) From: Wang Shilong To: linux-btrfs@vger.kernel.org Cc: dsterba@suse.cz, sandeen@redhat.com Subject: [PATCH 16/20] Btrfs-progs: fix magic return value in dir-test.c Date: Wed, 4 Sep 2013 23:22:33 +0800 Message-Id: <1378308157-4621-17-git-send-email-wangshilong1991@gmail.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1378308157-4621-1-git-send-email-wangshilong1991@gmail.com> References: <1378308157-4621-1-git-send-email-wangshilong1991@gmail.com> Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wang Shilong Signed-off-by: Wang Shilong --- dir-test.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/dir-test.c b/dir-test.c index d95219a..a54b777 100644 --- a/dir-test.c +++ b/dir-test.c @@ -140,7 +140,7 @@ fatal_release: btrfs_release_path(&path); fatal: printf("failed to insert %lu ret %d\n", oid, ret); - return -1; + return ret; } static int insert_dup(struct btrfs_trans_handle *trans, struct btrfs_root @@ -213,7 +213,7 @@ out_release: btrfs_release_path(path); out: printf("failed to delete %lu %d\n", radix_index, ret); - return -1; + return ret; } static int del_one(struct btrfs_trans_handle *trans, struct btrfs_root *root, @@ -241,7 +241,7 @@ static int del_one(struct btrfs_trans_handle *trans, struct btrfs_root *root, out_release: btrfs_release_path(&path); printf("failed to delete %lu %d\n", oid, ret); - return -1; + return ret; } static int lookup_item(struct btrfs_trans_handle *trans, struct btrfs_root @@ -269,7 +269,7 @@ static int lookup_item(struct btrfs_trans_handle *trans, struct btrfs_root btrfs_release_path(&path); if (ret) { printf("unable to find key %lu\n", oid); - return -1; + return ret; } return 0; } @@ -292,7 +292,7 @@ static int lookup_enoent(struct btrfs_trans_handle *trans, struct btrfs_root btrfs_release_path(&path); if (!ret) { printf("able to find key that should not exist %lu\n", oid); - return -1; + return ret; } return 0; } @@ -342,14 +342,14 @@ static int empty_tree(struct btrfs_trans_handle *trans, struct btrfs_root fprintf(stderr, "failed to remove %lu from tree\n", found); - return -1; + return ret; } if (!keep_running) break; } return 0; fprintf(stderr, "failed to delete from the radix %lu\n", found); - return -1; + return ret; } static int fill_tree(struct btrfs_trans_handle *trans, struct btrfs_root *root, @@ -512,6 +512,6 @@ int main(int ac, char **av) } out: close_ctree(root, &super); - return err; + return !!err; }