diff mbox

Btrfs-progs: make sure we return an error when we can't add a device

Message ID 1382363888-22588-1-git-send-email-jbacik@fusionio.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Josef Bacik Oct. 21, 2013, 1:58 p.m. UTC
I noticed xfstests was failing in a weird way but it was because our device add
was failing but not actually returning an error so we were failing further down
the test.  Fix this by making sure we return an error if we fail the mkfs tests.
Thanks,

Signed-off-by: Josef Bacik <jbacik@fusionio.com>
---
 cmds-device.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox

Patch

diff --git a/cmds-device.c b/cmds-device.c
index 6f32356..bc4a8dc 100644
--- a/cmds-device.c
+++ b/cmds-device.c
@@ -98,6 +98,7 @@  static int cmd_add_dev(int argc, char **argv)
 		res = test_dev_for_mkfs(argv[i], force, estr);
 		if (res) {
 			fprintf(stderr, "%s", estr);
+			ret++;
 			continue;
 		}