| Message ID | 1385445677-27762-1-git-send-email-miaox@cn.fujitsu.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Tue, Nov 26, 2013 at 02:01:17PM +0800, Miao Xie wrote: > Btrfs would crash when the users wrote some data into a file with compress > flag but the compression of the fs was disabled. This test case is to check > this bug still happen or not. > > Signed-off-by: Miao Xie <miaox@cn.fujitsu.com> > --- > Changlog v1 -> v2: > - address the commit from Dave Chinner. Testing every change before posting them for review is a good habit to develop. This: > + $XFS_IO_PROG -f -c "pwrite 0 1M" -c sync $work_file | _filter_xfs_io will dump this: wrote 1048576/1048576 bytes at offset 0 XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) command "sync" not found into the output file and hence the test will fail as the golden image file in the patch was not updated to match the new test output. It also points out that "-c sync" command is invalid - the command to fsync a file is "-c fsync". Cheers, Dave.
On tue, 26 Nov 2013 17:41:07 +1100, Dave Chinner wrote: > On Tue, Nov 26, 2013 at 02:01:17PM +0800, Miao Xie wrote: >> Btrfs would crash when the users wrote some data into a file with compress >> flag but the compression of the fs was disabled. This test case is to check >> this bug still happen or not. >> >> Signed-off-by: Miao Xie <miaox@cn.fujitsu.com> >> --- >> Changlog v1 -> v2: >> - address the commit from Dave Chinner. > > Testing every change before posting them for review is a good habit > to develop. This: > >> + $XFS_IO_PROG -f -c "pwrite 0 1M" -c sync $work_file | _filter_xfs_io > > will dump this: > > wrote 1048576/1048576 bytes at offset 0 > XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > command "sync" not found > > into the output file and hence the test will fail as the golden > image file in the patch was not updated to match the new test output. > > It also points out that "-c sync" command is invalid - the > command to fsync a file is "-c fsync". Sorry for my miss, please review the 3th one. Thanks Miao > > Cheers, > > Dave. > -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/tests/btrfs/022 b/tests/btrfs/022 new file mode 100755 index 0000000..2f32bf1 --- /dev/null +++ b/tests/btrfs/022 @@ -0,0 +1,83 @@ +#! /bin/bash +# FS QA Test No. btrfs/008 +# +# btrfs wrong compression type regression test. This test is used to check +# the oops will happen when the users write some data into the files whose +# compress flag is set but the compression of the fs is disabled. +# +#----------------------------------------------------------------------- +# Copyright (c) 2013 Fujitsu. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +# +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ + +status=1 # failure is the default! + +_cleanup() +{ + rm -f $tmp.* +} + +trap "_cleanup ; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs btrfs +_supported_os Linux +_require_scratch + +__workout() +{ + work_file="$SCRATCH_MNT/tmpfile" + + touch $work_file + chattr =c $work_file + $XFS_IO_PROG -f -c "pwrite 0 1M" -c sync $work_file | _filter_xfs_io +} + +echo "*** test nodatacow" +_scratch_mkfs > /dev/null 2>&1 +_scratch_mount "-o nodatacow" +__workout +_scratch_unmount +_check_scratch_fs + +echo "*** test compress=no" +_scratch_mkfs > /dev/null 2>&1 +_scratch_mount "-o compress=no" +__workout +_scratch_unmount +_check_scratch_fs + +echo "*** test compress-force=no" +_scratch_mkfs > /dev/null 2>&1 +_scratch_mount "-o compress-force=no" +__workout +_scratch_unmount +_check_scratch_fs + +echo "*** done" +status=0 ; exit diff --git a/tests/btrfs/022.out b/tests/btrfs/022.out new file mode 100644 index 0000000..611fd67 --- /dev/null +++ b/tests/btrfs/022.out @@ -0,0 +1,5 @@ +QA output created by 022 +*** test nodatacow +*** test compress=no +*** test compress-force=no +*** done diff --git a/tests/btrfs/group b/tests/btrfs/group index 410f8ed..c2adb2f 100644 --- a/tests/btrfs/group +++ b/tests/btrfs/group @@ -24,3 +24,4 @@ 019 auto quick 020 auto quick 021 auto quick +022 auto quick
Btrfs would crash when the users wrote some data into a file with compress flag but the compression of the fs was disabled. This test case is to check this bug still happen or not. Signed-off-by: Miao Xie <miaox@cn.fujitsu.com> --- Changlog v1 -> v2: - address the commit from Dave Chinner. --- tests/btrfs/022 | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/022.out | 5 ++++ tests/btrfs/group | 1 + 3 files changed, 89 insertions(+) create mode 100755 tests/btrfs/022 create mode 100644 tests/btrfs/022.out