| Message ID | 1391605052-15198-1-git-send-email-anand.jain@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
This patch was incomplete. Kindly ignore. Thanks, Anand On 02/05/14 08:57 PM, Anand Jain wrote: > btrfs_show_devname() is trying to know dev name with > lowest devid for a given FSID, so looping across the > FSID isn't necessary > > Signed-off-by: Anand Jain <anand.jain@oracle.com> > --- > fs/btrfs/super.c | 18 +++++++----------- > 1 files changed, 7 insertions(+), 11 deletions(-) > > diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c > index 378157c..6ed76d8 100644 > --- a/fs/btrfs/super.c > +++ b/fs/btrfs/super.c > @@ -1885,22 +1885,18 @@ static int btrfs_unfreeze(struct super_block *sb) > static int btrfs_show_devname(struct seq_file *m, struct dentry *root) > { > struct btrfs_fs_info *fs_info = btrfs_sb(root->d_sb); > - struct btrfs_fs_devices *cur_devices; > struct btrfs_device *dev, *first_dev = NULL; > struct list_head *head; > struct rcu_string *name; > > mutex_lock(&fs_info->fs_devices->device_list_mutex); > - cur_devices = fs_info->fs_devices; > - while (cur_devices) { > - head = &cur_devices->devices; > - list_for_each_entry(dev, head, dev_list) { > - if (dev->missing) > - continue; > - if (!first_dev || dev->devid < first_dev->devid) > - first_dev = dev; > - } > - cur_devices = cur_devices->seed; > + > + head = &fs_info->fs_devices->devices; > + list_for_each_entry(dev, head, dev_list) { > + if (dev->missing) > + continue; > + if (!first_dev || dev->devid < first_dev->devid) > + first_dev = dev; > } > > if (first_dev) { > -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 378157c..6ed76d8 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -1885,22 +1885,18 @@ static int btrfs_unfreeze(struct super_block *sb) static int btrfs_show_devname(struct seq_file *m, struct dentry *root) { struct btrfs_fs_info *fs_info = btrfs_sb(root->d_sb); - struct btrfs_fs_devices *cur_devices; struct btrfs_device *dev, *first_dev = NULL; struct list_head *head; struct rcu_string *name; mutex_lock(&fs_info->fs_devices->device_list_mutex); - cur_devices = fs_info->fs_devices; - while (cur_devices) { - head = &cur_devices->devices; - list_for_each_entry(dev, head, dev_list) { - if (dev->missing) - continue; - if (!first_dev || dev->devid < first_dev->devid) - first_dev = dev; - } - cur_devices = cur_devices->seed; + + head = &fs_info->fs_devices->devices; + list_for_each_entry(dev, head, dev_list) { + if (dev->missing) + continue; + if (!first_dev || dev->devid < first_dev->devid) + first_dev = dev; } if (first_dev) {
btrfs_show_devname() is trying to know dev name with lowest devid for a given FSID, so looping across the FSID isn't necessary Signed-off-by: Anand Jain <anand.jain@oracle.com> --- fs/btrfs/super.c | 18 +++++++----------- 1 files changed, 7 insertions(+), 11 deletions(-)