| Message ID | 1392025045-26201-1-git-send-email-bo.li.liu@oracle.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 1af34d0..e876c1e 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -4920,7 +4920,8 @@ void btrfs_invalidate_inodes(struct btrfs_root *root) struct inode *inode; u64 objectid = 0; - WARN_ON(btrfs_root_refs(&root->root_item) != 0); + if (!test_bit(BTRFS_FS_STATE_ERROR, &root->fs_info->fs_state)) + WARN_ON(btrfs_root_refs(&root->root_item) != 0); spin_lock(&root->inode_lock); again:
So after transaction is aborted, we need to cleanup inode resources by calling btrfs_invalidate_inodes(), and btrfs_invalidate_inodes() hopes roots' refs to be zero in old times and sets a WARN_ON(), however, this is not always true within cleaning up transaction, so we get to detect transaction abortion and not warn at all. Signed-off-by: Liu Bo <bo.li.liu@oracle.com> --- v2: Follow Josef's advice, ie. in case of aborting transaction, we no more warn. fs/btrfs/inode.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)