diff mbox

btrfs: reada: Remove unused function

Message ID 1420333197-6245-1-git-send-email-rickard_strandqvist@spectrumdigital.se
State Deferred
Headers show

Commit Message

Rickard Strandqvist Jan. 4, 2015, 12:59 a.m. UTC
Remove the function btrfs_reada_detach() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 fs/btrfs/ctree.h |    1 -
 fs/btrfs/reada.c |    9 +--------
 2 files changed, 1 insertion(+), 9 deletions(-)

Comments

David Sterba Jan. 5, 2015, 1:33 p.m. UTC | #1
On Sun, Jan 04, 2015 at 01:59:57AM +0100, Rickard Strandqvist wrote:
> Remove the function btrfs_reada_detach() that is not used anywhere.
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

No please, this function is part of public readahead API and similar
patch has been NACKed several times.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jiri Kosina Jan. 6, 2015, 10:42 a.m. UTC | #2
On Mon, 5 Jan 2015, David Sterba wrote:

> > Remove the function btrfs_reada_detach() that is not used anywhere.
> > 
> > This was partially found by using a static code analysis program called cppcheck.
> > 
> > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> 
> No please, this function is part of public readahead API and similar
> patch has been NACKed several times.

BTW how is this any kind of API for anybody, given it's not exported to 
modules?
David Sterba Jan. 6, 2015, 12:22 p.m. UTC | #3
On Tue, Jan 06, 2015 at 11:42:07AM +0100, Jiri Kosina wrote:
> On Mon, 5 Jan 2015, David Sterba wrote:
> 
> > > Remove the function btrfs_reada_detach() that is not used anywhere.
> > > 
> > > This was partially found by using a static code analysis program called cppcheck.
> > > 
> > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> > 
> > No please, this function is part of public readahead API and similar
> > patch has been NACKed several times.
> 
> BTW how is this any kind of API for anybody, given it's not exported to 
> modules?

Scratch 'public' from the sentence, that was misleading. The API is internal to
btrfs.  The readahead can work in synchronous and asynchronous modes, this
function is API to the async mode.

Documented at reada.c:

 34 /*
 35  * This is the implementation for the generic read ahead framework.
 36  *
 37  * To trigger a readahead, btrfs_reada_add must be called. It will start
 38  * a read ahead for the given range [start, end) on tree root. The returned
 39  * handle can either be used to wait on the readahead to finish
 40  * (btrfs_reada_wait), or to send it to the background (btrfs_reada_detach).
 41  *
...

I've experimented with it for readdir speedups, but I haven't finished that due
to other problems.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index fe69edd..030a7b5 100644
--- a/fs/btrfs/ctree.h
+++ b/fs/btrfs/ctree.h
@@ -4111,7 +4111,6 @@  struct reada_control {
 struct reada_control *btrfs_reada_add(struct btrfs_root *root,
 			      struct btrfs_key *start, struct btrfs_key *end);
 int btrfs_reada_wait(void *handle);
-void btrfs_reada_detach(void *handle);
 int btree_readahead_hook(struct btrfs_root *root, struct extent_buffer *eb,
 			 u64 start, int err);
 
diff --git a/fs/btrfs/reada.c b/fs/btrfs/reada.c
index b63ae20..97073c0c 100644
--- a/fs/btrfs/reada.c
+++ b/fs/btrfs/reada.c
@@ -37,7 +37,7 @@ 
  * To trigger a readahead, btrfs_reada_add must be called. It will start
  * a read ahead for the given range [start, end) on tree root. The returned
  * handle can either be used to wait on the readahead to finish
- * (btrfs_reada_wait), or to send it to the background (btrfs_reada_detach).
+ * (btrfs_reada_wait).
  *
  * The read ahead works as follows:
  * On btrfs_reada_add, the root of the tree is inserted into a radix_tree.
@@ -986,10 +986,3 @@  int btrfs_reada_wait(void *handle)
 	return 0;
 }
 #endif
-
-void btrfs_reada_detach(void *handle)
-{
-	struct reada_control *rc = handle;
-
-	kref_put(&rc->refcnt, reada_control_release);
-}