diff mbox

btrfs: transaction: Remove unused function

Message ID 1421175246-6448-1-git-send-email-rickard_strandqvist@spectrumdigital.se
State Changes Requested
Headers show

Commit Message

Rickard Strandqvist Jan. 13, 2015, 6:54 p.m. UTC
Remove the function btrfs_start_transaction_lflush() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 fs/btrfs/transaction.c |    7 -------
 fs/btrfs/transaction.h |    2 --
 2 files changed, 9 deletions(-)

Comments

David Sterba Jan. 14, 2015, 12:06 a.m. UTC | #1
On Tue, Jan 13, 2015 at 07:54:06PM +0100, Rickard Strandqvist wrote:
> Remove the function btrfs_start_transaction_lflush() that is not used anywhere.
> 
> This was partially found by using a static code analysis program called cppcheck.

http://thread.gmane.org/gmane.comp.file-systems.btrfs/27536

and this is my reply to 2nd attempt to remove the function:

"> btrfs_start_transaction_lflush()

Transcaction API, removing the func does not make sense without removing
BTRFS_RESERVE_FLUSH_LIMIT at the same time.
"
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
index dcaae36..51003ce 100644
--- a/fs/btrfs/transaction.c
+++ b/fs/btrfs/transaction.c
@@ -534,13 +534,6 @@  struct btrfs_trans_handle *btrfs_start_transaction(struct btrfs_root *root,
 				 BTRFS_RESERVE_FLUSH_ALL);
 }
 
-struct btrfs_trans_handle *btrfs_start_transaction_lflush(
-					struct btrfs_root *root, int num_items)
-{
-	return start_transaction(root, num_items, TRANS_START,
-				 BTRFS_RESERVE_FLUSH_LIMIT);
-}
-
 struct btrfs_trans_handle *btrfs_join_transaction(struct btrfs_root *root)
 {
 	return start_transaction(root, 0, TRANS_JOIN, 0);
diff --git a/fs/btrfs/transaction.h b/fs/btrfs/transaction.h
index d8f40e1..027e49e 100644
--- a/fs/btrfs/transaction.h
+++ b/fs/btrfs/transaction.h
@@ -136,8 +136,6 @@  int btrfs_end_transaction(struct btrfs_trans_handle *trans,
 			  struct btrfs_root *root);
 struct btrfs_trans_handle *btrfs_start_transaction(struct btrfs_root *root,
 						   int num_items);
-struct btrfs_trans_handle *btrfs_start_transaction_lflush(
-					struct btrfs_root *root, int num_items);
 struct btrfs_trans_handle *btrfs_join_transaction(struct btrfs_root *root);
 struct btrfs_trans_handle *btrfs_join_transaction_nolock(struct btrfs_root *root);
 struct btrfs_trans_handle *btrfs_attach_transaction(struct btrfs_root *root);