| Message ID | 1423695817-8895-1-git-send-email-anand.jain@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Adding Greg to CC. On Thu, Feb 12, 2015 at 07:03:37AM +0800, Anand Jain wrote: > drivers/cpufreq/cpufreq.c is already using this function. And now btrfs > needs it as well. export symbol kobject_move(). > > Signed-off-by: Anand Jain <anand.jain@oracle.com> > --- > v1->v2: Didn't notice there wasn't my signed-off, now added. Thanks Dave. > > lib/kobject.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/kobject.c b/lib/kobject.c > index 58751bb..e055c06 100644 > --- a/lib/kobject.c > +++ b/lib/kobject.c > @@ -548,6 +548,7 @@ out: > kfree(devpath); > return error; > } > +EXPORT_SYMBOL_GPL(kobject_move); Looks ok to me. There's another user of this function in drivers/cpufreq/cpufreq.c, but apparenly not a module so the export was not needed. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Feb 12, 2015 at 10:53:14AM +0100, David Sterba wrote: > Adding Greg to CC. > > On Thu, Feb 12, 2015 at 07:03:37AM +0800, Anand Jain wrote: > > drivers/cpufreq/cpufreq.c is already using this function. And now btrfs > > needs it as well. export symbol kobject_move(). > > > > Signed-off-by: Anand Jain <anand.jain@oracle.com> > > --- > > v1->v2: Didn't notice there wasn't my signed-off, now added. Thanks Dave. > > > > lib/kobject.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/kobject.c b/lib/kobject.c > > index 58751bb..e055c06 100644 > > --- a/lib/kobject.c > > +++ b/lib/kobject.c > > @@ -548,6 +548,7 @@ out: > > kfree(devpath); > > return error; > > } > > +EXPORT_SYMBOL_GPL(kobject_move); > > Looks ok to me. There's another user of this function in > drivers/cpufreq/cpufreq.c, but apparenly not a module so the export was > not needed. Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/lib/kobject.c b/lib/kobject.c index 58751bb..e055c06 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -548,6 +548,7 @@ out: kfree(devpath); return error; } +EXPORT_SYMBOL_GPL(kobject_move); /** * kobject_del - unlink kobject from hierarchy.
drivers/cpufreq/cpufreq.c is already using this function. And now btrfs needs it as well. export symbol kobject_move(). Signed-off-by: Anand Jain <anand.jain@oracle.com> --- v1->v2: Didn't notice there wasn't my signed-off, now added. Thanks Dave. lib/kobject.c | 1 + 1 file changed, 1 insertion(+)