diff mbox

[RFC] Btrfs-progs: remove compressed option from 'qgroup limit'

Message ID 1445340779-9084-1-git-send-email-bo.li.liu@oracle.com (mailing list archive)
State New, archived
Headers show

Commit Message

Liu Bo Oct. 20, 2015, 11:32 a.m. UTC 
The current design of btrfs quota doesn't support "quota limit after
compression" after 
commit e2d1f92399af ("btrfs: qgroup: do a reservation in a higher level.")

So remove it to make things clear.

Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
---
 Documentation/btrfs-qgroup.asciidoc | 4 ----
 cmds-qgroup.c                       | 9 ---------
 2 files changed, 13 deletions(-)
diff mbox

Patch

diff --git a/Documentation/btrfs-qgroup.asciidoc b/Documentation/btrfs-qgroup.asciidoc
index 57cf012..454b074 100644
--- a/Documentation/btrfs-qgroup.asciidoc
+++ b/Documentation/btrfs-qgroup.asciidoc
@@ -73,10 +73,6 @@  is used if possible.
 +
 `Options`
 +
--c::::
-limit amount of data after compression. This is the default, it is currently not
-possible to turn off this option.
-+
 -e::::
 limit space exclusively assigned to this qgroup.
 
diff --git a/cmds-qgroup.c b/cmds-qgroup.c
index 48c1733..9f76232 100644
--- a/cmds-qgroup.c
+++ b/cmds-qgroup.c
@@ -382,8 +382,6 @@  static const char * const cmd_qgroup_limit_usage[] = {
 	"btrfs qgroup limit [options] <size>|none [<qgroupid>] <path>",
 	"Set the limits a subvolume quota group.",
 	"",
-	"-c   limit amount of data after compression. This is the default,",
-	"     it is currently not possible to turn off this option.",
 	"-e   limit space exclusively assigned to this qgroup",
 	NULL
 };
@@ -396,7 +394,6 @@  static int cmd_qgroup_limit(int argc, char **argv)
 	char *path = NULL;
 	struct btrfs_ioctl_qgroup_limit_args args;
 	unsigned long long size;
-	int compressed = 0;
 	int exclusive = 0;
 	DIR *dirstream = NULL;
 
@@ -406,9 +403,6 @@  static int cmd_qgroup_limit(int argc, char **argv)
 		if (c < 0)
 			break;
 		switch (c) {
-		case 'c':
-			compressed = 1;
-			break;
 		case 'e':
 			exclusive = 1;
 			break;
@@ -426,9 +420,6 @@  static int cmd_qgroup_limit(int argc, char **argv)
 	}
 
 	memset(&args, 0, sizeof(args));
-	if (compressed)
-		args.lim.flags |= BTRFS_QGROUP_LIMIT_RFER_CMPR |
-				  BTRFS_QGROUP_LIMIT_EXCL_CMPR;
 	if (exclusive) {
 		args.lim.flags |= BTRFS_QGROUP_LIMIT_MAX_EXCL;
 		args.lim.max_exclusive = size;