From patchwork Wed Nov 4 09:58:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Filipe Manana X-Patchwork-Id: 7548591 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6455D9F2F7 for ; Wed, 4 Nov 2015 09:58:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 65AA1206B0 for ; Wed, 4 Nov 2015 09:58:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3830F206AF for ; Wed, 4 Nov 2015 09:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932492AbbKDJ6S (ORCPT ); Wed, 4 Nov 2015 04:58:18 -0500 Received: from mail.kernel.org ([198.145.29.136]:44798 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932339AbbKDJ6P (ORCPT ); Wed, 4 Nov 2015 04:58:15 -0500 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 91BA1206B0; Wed, 4 Nov 2015 09:58:14 +0000 (UTC) Received: from debian3.lan (bl8-199-62.dsl.telepac.pt [85.241.199.62]) (using TLSv1.2 with cipher AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1845C206AF; Wed, 4 Nov 2015 09:58:12 +0000 (UTC) From: fdmanana@kernel.org To: fstests@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, Filipe Manana Subject: [PATCH v2] fstests: generic test for fsync after hole punching Date: Wed, 4 Nov 2015 09:58:08 +0000 Message-Id: <1446631088-4319-1-git-send-email-fdmanana@kernel.org> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1446467577-32220-1-git-send-email-fdmanana@kernel.org> References: <1446467577-32220-1-git-send-email-fdmanana@kernel.org> X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Filipe Manana Test that a file fsync works after punching a hole for the same file range multiple times, and that after log/journal replay the file's content and layout are correct. This test is motivated by a bug found in btrfs, which is fixed by the following linux kernel patch: "Btrfs: fix hole punching when using the no-holes feature" Signed-off-by: Filipe Manana --- V2: Removed setting -O no-holes for MKFS_OPTIONS when the fs being tested is btrfs. Made the test use the new function _flakey_drop_and_remount, suggested by Dave Chinner, which is introduced by: "[PATCH] fstests: add helper function _flakey_drop_and_remount" tests/generic/110 | 108 ++++++++++++++++++++++++++++++++++++++++++++++++++ tests/generic/110.out | 13 ++++++ tests/generic/group | 1 + 3 files changed, 122 insertions(+) create mode 100755 tests/generic/110 create mode 100644 tests/generic/110.out diff --git a/tests/generic/110 b/tests/generic/110 new file mode 100755 index 0000000..08aa883 --- /dev/null +++ b/tests/generic/110 @@ -0,0 +1,108 @@ +#! /bin/bash +# FSQA Test No. 110 +# +# Test that a file fsync works after punching a hole for the same file range +# multiple times and that after log/journal replay the file's content is +# correct. +# +# This test is motivated by a bug found in btrfs. +# +#----------------------------------------------------------------------- +# +# Copyright (C) 2015 SUSE Linux Products GmbH. All Rights Reserved. +# Author: Filipe Manana +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + _cleanup_flakey + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/punch +. ./common/dmflakey + +# real QA test starts here +_need_to_be_root +_supported_fs generic +_supported_os Linux +_require_scratch +_require_xfs_io_command "fpunch" +_require_xfs_io_command "fiemap" +_require_dm_target flakey +_require_metadata_journaling $SCRATCH_DEV + +rm -f $seqres.full + +_scratch_mkfs >>$seqres.full 2>&1 +_init_flakey +_mount_flakey + +# Create out test file with some data and then fsync it. +# We do the fsync only to make sure the last fsync we do in this test triggers +# the fast code path of btrfs' fsync implementation, a condition necessary to +# trigger the bug btrfs had. +$XFS_IO_PROG -f -c "pwrite -S 0xaa 0K 128K" \ + -c "fsync" \ + $SCRATCH_MNT/foobar | _filter_xfs_io + +# Now punch a hole against the range [96K, 128K[. +$XFS_IO_PROG -c "fpunch 96K 32K" $SCRATCH_MNT/foobar + +# Punch another hole against a range that overlaps the previous range and ends +# beyond eof. +$XFS_IO_PROG -c "fpunch 64K 128K" $SCRATCH_MNT/foobar + +# Punch another hole against a range that overlaps the first range ([96K, 128K[) +# and ends at eof. +$XFS_IO_PROG -c "fpunch 32K 96K" $SCRATCH_MNT/foobar + +# Fsync our file. We want to verify that, after a power failure and mounting the +# filesystem again, the file content reflects all the hole punch operations. +$XFS_IO_PROG -c "fsync" $SCRATCH_MNT/foobar + +echo "File digest before power failure:" +md5sum $SCRATCH_MNT/foobar | _filter_scratch + +echo "Fiemap before power failure:" +$XFS_IO_PROG -c "fiemap -v" $SCRATCH_MNT/foobar | _filter_fiemap + +_flakey_drop_and_remount + +echo "File digest after log replay:" +# Must match the same digest we got before the power failure. +md5sum $SCRATCH_MNT/foobar | _filter_scratch + +echo "Fiemap after log replay:" +# Must match the same extent listing we got before the power failure. +$XFS_IO_PROG -c "fiemap -v" $SCRATCH_MNT/foobar | _filter_fiemap + +_unmount_flakey + +status=0 +exit diff --git a/tests/generic/110.out b/tests/generic/110.out new file mode 100644 index 0000000..ba016c8 --- /dev/null +++ b/tests/generic/110.out @@ -0,0 +1,13 @@ +QA output created by 110 +wrote 131072/131072 bytes at offset 0 +XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +File digest before power failure: +d26bbb9a8396a9c0dd76423471b72b15 SCRATCH_MNT/foobar +Fiemap before power failure: +0: [0..63]: data +1: [64..255]: hole +File digest after log replay: +d26bbb9a8396a9c0dd76423471b72b15 SCRATCH_MNT/foobar +Fiemap after log replay: +0: [0..63]: data +1: [64..255]: hole diff --git a/tests/generic/group b/tests/generic/group index 1dd4269..59a6f43 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -112,6 +112,7 @@ 107 auto quick metadata 108 auto quick rw 109 auto metadata dir +110 auto quick prealloc metadata 112 rw aio auto quick 113 rw aio auto quick 114 rw aio auto quick