From patchwork Thu Nov 5 00:50:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Maggard X-Patchwork-Id: 7556131 Return-Path: X-Original-To: patchwork-linux-btrfs@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 47737BEEA4 for ; Thu, 5 Nov 2015 00:50:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6471E204D6 for ; Thu, 5 Nov 2015 00:50:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6C39200C1 for ; Thu, 5 Nov 2015 00:50:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965567AbbKEAup (ORCPT ); Wed, 4 Nov 2015 19:50:45 -0500 Received: from mail-pa0-f43.google.com ([209.85.220.43]:36332 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964795AbbKEAun (ORCPT ); Wed, 4 Nov 2015 19:50:43 -0500 Received: by pacdm15 with SMTP id dm15so44413479pac.3; Wed, 04 Nov 2015 16:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=Hdei8AImihB9MJinpqVOcvIiYXdZr08Wt4VUYwIGjho=; b=RnXGIp5QjEmvTfoW18m1CDINg1vluBE0lQHmUdkhQ5Q0dmVFzrQ84r2fY03U8jft4b wPBkcht1VnPseEXA6MksRBkxMJaWa/CUAtHrNm6LmyiFBGt3+5ReF+el2wsWxrMwiWuI eKgvUh94g1xXxWQvNH82N3yaWojMd1mzczXCSLGFcDAb8pr80GbOg33TMI0yRpwaFPhi YKjQZtOP7A/X3zNdFYjEKqeSGolzoFWZeAd9kvZyG4mkpYeLQW03ma9ABOTl32KRD7xZ +1GGGD2SbQHFmWvUv4qWqKoZ157mGgH2OIJtcGmdNN1Z5bZmt2lLsRmI0LexWOzriESv OXiw== X-Received: by 10.68.228.228 with SMTP id sl4mr5754040pbc.51.1446684642835; Wed, 04 Nov 2015 16:50:42 -0800 (PST) Received: from jmaggard-ThinkPad-W520.infrant-6.com ([209.249.181.1]) by smtp.gmail.com with ESMTPSA id sx1sm4283826pbc.36.2015.11.04.16.50.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 04 Nov 2015 16:50:42 -0800 (PST) From: Justin Maggard X-Google-Original-From: Justin Maggard To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Cc: Justin Maggard Subject: [PATCH v2] btrfs: test unmount during quota rescan Date: Wed, 4 Nov 2015 16:50:36 -0800 Message-Id: <1446684636-32730-1-git-send-email-jmaggard@netgear.com> X-Mailer: git-send-email 2.6.2 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This test case tests if we are able to unmount a filesystem while a quota rescan is running. Up to now (4.3) this would result in a kernel NULL pointer dereference. Fixed by patch (btrfs: qgroup: exit the rescan worker during umount). Signed-off-by: Justin Maggard Reviewed-by: Filipe Manana --- tests/btrfs/114 | 61 +++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/btrfs/114.out | 2 ++ tests/btrfs/group | 1 + 3 files changed, 64 insertions(+) create mode 100644 tests/btrfs/114 create mode 100644 tests/btrfs/114.out diff --git a/tests/btrfs/114 b/tests/btrfs/114 new file mode 100644 index 0000000..0a0e8ba --- /dev/null +++ b/tests/btrfs/114 @@ -0,0 +1,61 @@ +#! /bin/bash +# FS QA Test No. btrfs/114 +# +# btrfs quota scan/unmount sanity test +# Make sure that unmounting during a quota rescan doesn't crash +# +#----------------------------------------------------------------------- +# Copyright (c) 2015 NETGEAR, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs btrfs +_supported_os Linux +_require_scratch + +_scratch_mkfs >>$seqres.full 2>&1 +_scratch_mount + +for i in `seq 0 1 450000`; do + echo -n > $SCRATCH_MNT/file.$i +done +echo 3 > /proc/sys/vm/drop_caches +$BTRFS_UTIL_PROG quota enable $SCRATCH_MNT +_scratch_unmount + +echo "Silence is golden" +status=0 +exit diff --git a/tests/btrfs/114.out b/tests/btrfs/114.out new file mode 100644 index 0000000..a2aa4a2 --- /dev/null +++ b/tests/btrfs/114.out @@ -0,0 +1,2 @@ +QA output created by 114 +Silence is golden diff --git a/tests/btrfs/group b/tests/btrfs/group index 7cf7dd7..10ab26b 100644 --- a/tests/btrfs/group +++ b/tests/btrfs/group @@ -116,3 +116,4 @@ 111 auto quick send 112 auto quick clone 113 auto quick compress clone +114 auto qgroup