| Message ID | 1457736845-27783-1-git-send-email-ashish.samant@oracle.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, Mar 11, 2016 at 02:54:05PM -0800, Ashish Samant wrote: > Dont print warning for ENOSPC error unless ENOSPC_DEBUG is enabled. Use > btrfs_debug if it is enabled. > > Signed-off-by: Ashish Samant <ashish.samant@oracle.com> > > V3: > - Use btrfs_debug() instead of WARN() per David Sterba's comment. > V2: > - Add a commit message. > --- > fs/btrfs/delayed-inode.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c > index b57daa8..b7e44cc 100644 > --- a/fs/btrfs/delayed-inode.c > +++ b/fs/btrfs/delayed-inode.c > @@ -651,9 +651,12 @@ static int btrfs_delayed_inode_reserve_metadata( > goto out; > > ret = btrfs_block_rsv_migrate(src_rsv, dst_rsv, num_bytes); > - if (!WARN_ON(ret)) > + if (!ret) > goto out; > > + if (btrfs_test_opt(root, ENOSPC_DEBUG)) > + btrfs_debug(root->fs_info, > + "block rsv migrate returned %d\n", ret); the message helpers do not need \n, I'll fix it here. Reviewed-by: David Sterba <dsterba@suse.com> -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c index b57daa8..b7e44cc 100644 --- a/fs/btrfs/delayed-inode.c +++ b/fs/btrfs/delayed-inode.c @@ -651,9 +651,12 @@ static int btrfs_delayed_inode_reserve_metadata( goto out; ret = btrfs_block_rsv_migrate(src_rsv, dst_rsv, num_bytes); - if (!WARN_ON(ret)) + if (!ret) goto out; + if (btrfs_test_opt(root, ENOSPC_DEBUG)) + btrfs_debug(root->fs_info, + "block rsv migrate returned %d\n", ret); /* * Ok this is a problem, let's just steal from the global rsv * since this really shouldn't happen that often.
Dont print warning for ENOSPC error unless ENOSPC_DEBUG is enabled. Use btrfs_debug if it is enabled. Signed-off-by: Ashish Samant <ashish.samant@oracle.com> V3: - Use btrfs_debug() instead of WARN() per David Sterba's comment. V2: - Add a commit message. --- fs/btrfs/delayed-inode.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)