diff mbox

[V20,19/19] Btrfs: subpage-blocksize: Rate limit scrub error message

Message ID 1467606879-14181-20-git-send-email-chandan@linux.vnet.ibm.com (mailing list archive)
State Accepted
Headers show

Commit Message

Chandan Rajendra July 4, 2016, 4:34 a.m. UTC
btrfs/073 invokes scrub ioctl in a tight loop. In subpage-blocksize
scenario this results in a lot of "scrub: size assumption sectorsize !=
PAGE_SIZE " messages being printed on the console. To reduce the number
of such messages this commit uses btrfs_err_rl() instead of
btrfs_err().

Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
---
 fs/btrfs/scrub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Sterba July 12, 2016, 4:06 p.m. UTC | #1
On Mon, Jul 04, 2016 at 10:04:39AM +0530, Chandan Rajendra wrote:
> btrfs/073 invokes scrub ioctl in a tight loop. In subpage-blocksize
> scenario this results in a lot of "scrub: size assumption sectorsize !=
> PAGE_SIZE " messages being printed on the console. To reduce the number
> of such messages this commit uses btrfs_err_rl() instead of
> btrfs_err().
> 
> Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>

I'll pick this one independently.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c
index 86270c6..68c8a09 100644
--- a/fs/btrfs/scrub.c
+++ b/fs/btrfs/scrub.c
@@ -3856,7 +3856,7 @@  int btrfs_scrub_dev(struct btrfs_fs_info *fs_info, u64 devid, u64 start,
 
 	if (fs_info->chunk_root->sectorsize != PAGE_SIZE) {
 		/* not supported for data w/o checksums */
-		btrfs_err(fs_info,
+		btrfs_err_rl(fs_info,
 			   "scrub: size assumption sectorsize != PAGE_SIZE "
 			   "(%d != %lu) fails",
 		       fs_info->chunk_root->sectorsize, PAGE_SIZE);