| Message ID | 1512463189-24724-2-git-send-email-nborisov@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2017年12月05日 16:39, Nikolay Borisov wrote: > Signed-off-by: Nikolay Borisov <nborisov@suse.com> > --- > tests/README.md | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/README.md b/tests/README.md > index 04d2ce2ab40d..c456018554cc 100644 > --- a/tests/README.md > +++ b/tests/README.md > @@ -164,7 +164,9 @@ how to do mkfs, mount, unmount, check, etc. > and join by dashes `-`. This will become the directory name, eg. `012-subvolume-sync-must-wait`. > > 3. Write a short description of the bug and how it's tested to the comment at the > -begining of `test.sh`. You don't need to add the file to git yet. > +begining of `test.sh`. You don't need to add the file to git yet. Don't forget > +to make the file executable, otherwise it's not going to be executed by the > +infrastructure. This comment is really needed, as myself also sometimes forget to do that. Reviewed-by: <wqu@suse.com> Thanks, Qu > > 4. Write the test commands, comment anything that's not obvious. > >
diff --git a/tests/README.md b/tests/README.md index 04d2ce2ab40d..c456018554cc 100644 --- a/tests/README.md +++ b/tests/README.md @@ -164,7 +164,9 @@ how to do mkfs, mount, unmount, check, etc. and join by dashes `-`. This will become the directory name, eg. `012-subvolume-sync-must-wait`. 3. Write a short description of the bug and how it's tested to the comment at the -begining of `test.sh`. You don't need to add the file to git yet. +begining of `test.sh`. You don't need to add the file to git yet. Don't forget +to make the file executable, otherwise it's not going to be executed by the +infrastructure. 4. Write the test commands, comment anything that's not obvious.
Signed-off-by: Nikolay Borisov <nborisov@suse.com> --- tests/README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)