| Message ID | 1536112527-16758-1-git-send-email-bo.liu@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] Btrfs: remove confusing tracepoint in btrfs_add_reserved_bytes | expand |
On 5.09.2018 04:55, Liu Bo wrote: > Here we're not releasing any space, but transferring bytes from > ->bytes_may_use to ->bytes_reserved. > > Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com> Reviewed-by: Nikolay Borisov <nborisov@suse.com> > --- > v2: Add missing commit log. > > fs/btrfs/extent-tree.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c > index 41a02cbb5a4a..76ee5ebef2b9 100644 > --- a/fs/btrfs/extent-tree.c > +++ b/fs/btrfs/extent-tree.c > @@ -6401,10 +6401,6 @@ static int btrfs_add_reserved_bytes(struct btrfs_block_group_cache *cache, > } else { > cache->reserved += num_bytes; > space_info->bytes_reserved += num_bytes; > - > - trace_btrfs_space_reservation(cache->fs_info, > - "space_info", space_info->flags, > - ram_bytes, 0); > space_info->bytes_may_use -= ram_bytes; > if (delalloc) > cache->delalloc_bytes += num_bytes; >
On Wed, Sep 05, 2018 at 09:55:27AM +0800, Liu Bo wrote: > Here we're not releasing any space, but transferring bytes from > ->bytes_may_use to ->bytes_reserved. > > Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com> > --- > v2: Add missing commit log. I've enhanced the changlog a bit how the tracepoint got there. Reviewed-by: David Sterba <dsterba@suse.com>
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index 41a02cbb5a4a..76ee5ebef2b9 100644 --- a/fs/btrfs/extent-tree.c +++ b/fs/btrfs/extent-tree.c @@ -6401,10 +6401,6 @@ static int btrfs_add_reserved_bytes(struct btrfs_block_group_cache *cache, } else { cache->reserved += num_bytes; space_info->bytes_reserved += num_bytes; - - trace_btrfs_space_reservation(cache->fs_info, - "space_info", space_info->flags, - ram_bytes, 0); space_info->bytes_may_use -= ram_bytes; if (delalloc) cache->delalloc_bytes += num_bytes;
Here we're not releasing any space, but transferring bytes from ->bytes_may_use to ->bytes_reserved. Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com> --- v2: Add missing commit log. fs/btrfs/extent-tree.c | 4 ---- 1 file changed, 4 deletions(-)